Skip to content

Commit f64cfd8

Browse files
Hannes Reineckekawasaki
authored andcommitted
block: add 'read_keys' persistent reservation ioctl
The persistent reservation operations already have a callback for 'read_keys', but this is not accessible via an ioctl (unlike the other callbacks). So add a new persistent reservation ioctl 'READ_KEYS' to allow userspace to use this functionality. Signed-off-by: Hannes Reinecke <[email protected]>
1 parent 3d460ec commit f64cfd8

3 files changed

Lines changed: 46 additions & 6 deletions

File tree

block/ioctl.c

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -422,6 +422,43 @@ static int blkdev_pr_clear(struct block_device *bdev, blk_mode_t mode,
422422
return ops->pr_clear(bdev, c.key);
423423
}
424424

425+
static int blkdev_pr_read_keys(struct block_device *bdev, blk_mode_t mode,
426+
struct pr_keys __user *arg)
427+
{
428+
const struct pr_ops *ops = bdev->bd_disk->fops->pr_ops;
429+
struct pr_keys k_in, *k_out;
430+
size_t k_len;
431+
int ret, num_keys;
432+
433+
if (!blkdev_pr_allowed(bdev, mode))
434+
return -EPERM;
435+
if (!ops || !ops->pr_read_keys)
436+
return -EOPNOTSUPP;
437+
438+
if (copy_from_user(&k_in, arg, sizeof(k_in)))
439+
return -EFAULT;
440+
441+
num_keys = k_in.num_keys;
442+
k_out = kzalloc(sizeof(struct pr_keys) + num_keys * sizeof(u64),
443+
GFP_KERNEL);
444+
if (!k_out)
445+
return -ENOMEM;
446+
447+
k_out->num_keys = num_keys;
448+
ret = ops->pr_read_keys(bdev, k_out);
449+
if (ret) {
450+
kfree(k_out);
451+
return ret;
452+
}
453+
454+
k_len = sizeof(k_in) + num_keys * sizeof(u64);
455+
if (copy_to_user(arg, k_out, k_len))
456+
ret = -EFAULT;
457+
458+
kfree(k_out);
459+
return ret;
460+
}
461+
425462
static int blkdev_flushbuf(struct block_device *bdev, unsigned cmd,
426463
unsigned long arg)
427464
{
@@ -643,6 +680,8 @@ static int blkdev_common_ioctl(struct block_device *bdev, blk_mode_t mode,
643680
return blkdev_pr_preempt(bdev, mode, argp, true);
644681
case IOC_PR_CLEAR:
645682
return blkdev_pr_clear(bdev, mode, argp);
683+
case IOC_PR_READ_KEYS:
684+
return blkdev_pr_read_keys(bdev, mode, argp);
646685
default:
647686
return -ENOIOCTLCMD;
648687
}

include/linux/pr.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,6 @@
44

55
#include <uapi/linux/pr.h>
66

7-
struct pr_keys {
8-
u32 generation;
9-
u32 num_keys;
10-
u64 keys[];
11-
};
12-
137
struct pr_held_reservation {
148
u64 key;
159
u32 generation;

include/uapi/linux/pr.h

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,12 @@ struct pr_clear {
5656
__u32 __pad;
5757
};
5858

59+
struct pr_keys {
60+
__u32 generation;
61+
__u32 num_keys;
62+
__u64 keys[];
63+
};
64+
5965
#define PR_FL_IGNORE_KEY (1 << 0) /* ignore existing key */
6066

6167
#define IOC_PR_REGISTER _IOW('p', 200, struct pr_registration)
@@ -64,5 +70,6 @@ struct pr_clear {
6470
#define IOC_PR_PREEMPT _IOW('p', 203, struct pr_preempt)
6571
#define IOC_PR_PREEMPT_ABORT _IOW('p', 204, struct pr_preempt)
6672
#define IOC_PR_CLEAR _IOW('p', 205, struct pr_clear)
73+
#define IOC_PR_READ_KEYS _IOWR('p', 206, struct pr_keys)
6774

6875
#endif /* _UAPI_PR_H */

0 commit comments

Comments
 (0)