Skip to content

Commit f0f367a

Browse files
pchelkin91kuba-moo
authored andcommitted
net: macb: properly unregister fixed rate clocks
The additional resources allocated with clk_register_fixed_rate() need to be released with clk_unregister_fixed_rate(), otherwise they are lost. Fixes: 83a77e9 ("net: macb: Added PCI wrapper for Platform Driver.") Signed-off-by: Fedor Pchelkin <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent ce8fe52 commit f0f367a

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

drivers/net/ethernet/cadence/macb_pci.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,10 +96,10 @@ static int macb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
9696
return 0;
9797

9898
err_plat_dev_register:
99-
clk_unregister(plat_data.hclk);
99+
clk_unregister_fixed_rate(plat_data.hclk);
100100

101101
err_hclk_register:
102-
clk_unregister(plat_data.pclk);
102+
clk_unregister_fixed_rate(plat_data.pclk);
103103

104104
err_pclk_register:
105105
return err;
@@ -113,8 +113,8 @@ static void macb_remove(struct pci_dev *pdev)
113113
struct clk *hclk = plat_data->hclk;
114114

115115
platform_device_unregister(plat_dev);
116-
clk_unregister(pclk);
117-
clk_unregister(hclk);
116+
clk_unregister_fixed_rate(pclk);
117+
clk_unregister_fixed_rate(hclk);
118118
}
119119

120120
static const struct pci_device_id dev_id_table[] = {

0 commit comments

Comments
 (0)