Skip to content

Commit eb30942

Browse files
rbmarliererostedt
authored andcommitted
ktest: Resolve LOG_FILE in test option context
LOG_FILE is expanded immediately after the config file is parsed with eval_option(..., -1). That uses the default context, not the same option resolution path used for tests. If LOG_FILE depends on options that are finalized per test, it can be resolved from stale values before the first test starts. Resolve LOG_FILE through set_test_option("LOG_FILE", 1) instead so it uses the same expansion rules as the rest of the test options. Cc: John Hawley <[email protected]> Cc: Andrea Righi <[email protected]> Cc: Marcos Paulo de Souza <[email protected]> Cc: Matthieu Baerts <[email protected]> Cc: Fernando Fernandez Mancera <[email protected]> Cc: Pedro Falcato <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Ricardo B. Marlière <[email protected]> Signed-off-by: Steven Rostedt <[email protected]>
1 parent 057854f commit eb30942

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/testing/ktest/ktest.pl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4391,7 +4391,7 @@ sub die_usage {
43914391
read_config $ktest_config;
43924392

43934393
if (defined($opt{"LOG_FILE"})) {
4394-
$opt{"LOG_FILE"} = eval_option("LOG_FILE", $opt{"LOG_FILE"}, -1);
4394+
$opt{"LOG_FILE"} = set_test_option("LOG_FILE", 1);
43954395
}
43964396

43974397
# Append any configs entered in manually to the config file.

0 commit comments

Comments
 (0)