Skip to content

Commit e89b572

Browse files
committed
hfsplus: set ctime after setxattr and removexattr
The generic/728 test-case complains that: (1) Expected ctime needs to be changed after setxattr; (2) Expected ctime needs to be changed after removexattr. This patch adds calling inode_set_ctime_current() in __hfsplus_setxattr() and hfsplus_removexattr(). sudo ./check generic/728 FSTYP -- hfsplus PLATFORM -- Linux/x86_64 hfsplus-testing-0001 7.0.0-rc1+ #6 SMP PREEMPT_DYNAMIC Mon Mar 9 14:29:30 PDT 2026 MKFS_OPTIONS -- /dev/loop51 MOUNT_OPTIONS -- /dev/loop51 /mnt/scratch generic/728 35s ... 44s Ran: generic/728 Passed all 1 tests cc: John Paul Adrian Glaubitz <[email protected]> cc: Yangtao Li <[email protected]> cc: [email protected] Signed-off-by: Viacheslav Dubeyko <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Viacheslav Dubeyko <[email protected]>
1 parent b6b5922 commit e89b572

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

fs/hfsplus/xattr.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,8 @@ int __hfsplus_setxattr(struct inode *inode, const char *name,
410410
goto end_setxattr;
411411
}
412412

413+
inode_set_ctime_current(inode);
414+
413415
end_setxattr:
414416
hfs_find_exit(&cat_fd);
415417
hfs_dbg("finished: res %d\n", err);
@@ -895,6 +897,8 @@ static int hfsplus_removexattr(struct inode *inode, const char *name)
895897
goto end_removexattr;
896898
}
897899

900+
inode_set_ctime_current(inode);
901+
898902
end_removexattr:
899903
hfs_find_exit(&cat_fd);
900904

0 commit comments

Comments
 (0)