netlink: specs: rt-link: add missing byte-order properties

kuba-moo · Paolo Abeni · commit de92258e3b22 · 2025-06-05T12:50:10.000+02:00
A number of fields in the ip tunnels are lacking the big-endian designation. I suspect this is not intentional, as decoding the ports with the right endian seems objectively beneficial. Fixes: 6ffdbb9 ("netlink: specs: rt_link: decode ip6tnl, vti and vti6 link attrs") Fixes: 077b602 ("doc/netlink/specs: Add sub-message type to rt_link family") Signed-off-by: Jakub Kicinski <kuba@kernel.org> Reviewed-by: Donald Hunter <donald.hunter@gmail.com> Link: https://patch.msgid.link/20250603135357.502626-2-kuba@kernel.org Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
@@ -1685,15 +1685,19 @@ attribute-sets:
       -
         name: iflags
         type: u16
+        byte-order: big-endian
       -
         name: oflags
         type: u16
+        byte-order: big-endian
       -
         name: ikey
         type: u32
+        byte-order: big-endian
       -
         name: okey
         type: u32
+        byte-order: big-endian
       -
         name: local
         type: binary
@@ -1717,6 +1721,7 @@ attribute-sets:
       -
         name: flowinfo
         type: u32
+        byte-order: big-endian
       -
         name: flags
         type: u32
@@ -1729,9 +1734,11 @@ attribute-sets:
       -
         name: encap-sport
         type: u16
+        byte-order: big-endian
       -
         name: encap-dport
         type: u16
+        byte-order: big-endian
       -
         name: collect-metadata
         type: flag
@@ -1764,9 +1771,11 @@ attribute-sets:
       -
         name: ikey
         type: u32
+        byte-order: big-endian
       -
         name: okey
         type: u32
+        byte-order: big-endian
       -
         name: local
         type: binary
@@ -1816,6 +1825,7 @@ attribute-sets:
       -
         name: port
         type: u16
+        byte-order: big-endian
       -
         name: collect-metadata
         type: flag
@@ -1835,6 +1845,7 @@ attribute-sets:
       -
         name: label
         type: u32
+        byte-order: big-endian
       -
         name: ttl-inherit
         type: u8
@@ -1875,9 +1886,11 @@ attribute-sets:
       -
         name: flowinfo
         type: u32
+        byte-order: big-endian
       -
         name: flags
         type: u16
+        byte-order: big-endian
       -
         name: proto
         type: u8
@@ -1907,9 +1920,11 @@ attribute-sets:
       -
         name: encap-sport
         type: u16
+        byte-order: big-endian
       -
         name: encap-dport
         type: u16
+        byte-order: big-endian
       -
         name: collect-metadata
         type: flag

Original file line number	Diff line number	Diff line change
`@@ -1685,15 +1685,19 @@ attribute-sets:`
`1685`	`1685`	`-`
`1686`	`1686`	`name: iflags`
`1687`	`1687`	`type: u16`
	`1688`	`+ byte-order: big-endian`
`1688`	`1689`	`-`
`1689`	`1690`	`name: oflags`
`1690`	`1691`	`type: u16`
	`1692`	`+ byte-order: big-endian`
`1691`	`1693`	`-`
`1692`	`1694`	`name: ikey`
`1693`	`1695`	`type: u32`
	`1696`	`+ byte-order: big-endian`
`1694`	`1697`	`-`
`1695`	`1698`	`name: okey`
`1696`	`1699`	`type: u32`
	`1700`	`+ byte-order: big-endian`
`1697`	`1701`	`-`
`1698`	`1702`	`name: local`
`1699`	`1703`	`type: binary`
`@@ -1717,6 +1721,7 @@ attribute-sets:`
`1717`	`1721`	`-`
`1718`	`1722`	`name: flowinfo`
`1719`	`1723`	`type: u32`
	`1724`	`+ byte-order: big-endian`
`1720`	`1725`	`-`
`1721`	`1726`	`name: flags`
`1722`	`1727`	`type: u32`
`@@ -1729,9 +1734,11 @@ attribute-sets:`
`1729`	`1734`	`-`
`1730`	`1735`	`name: encap-sport`
`1731`	`1736`	`type: u16`
	`1737`	`+ byte-order: big-endian`
`1732`	`1738`	`-`
`1733`	`1739`	`name: encap-dport`
`1734`	`1740`	`type: u16`
	`1741`	`+ byte-order: big-endian`
`1735`	`1742`	`-`
`1736`	`1743`	`name: collect-metadata`
`1737`	`1744`	`type: flag`
`@@ -1764,9 +1771,11 @@ attribute-sets:`
`1764`	`1771`	`-`
`1765`	`1772`	`name: ikey`
`1766`	`1773`	`type: u32`
	`1774`	`+ byte-order: big-endian`
`1767`	`1775`	`-`
`1768`	`1776`	`name: okey`
`1769`	`1777`	`type: u32`
	`1778`	`+ byte-order: big-endian`
`1770`	`1779`	`-`
`1771`	`1780`	`name: local`
`1772`	`1781`	`type: binary`
`@@ -1816,6 +1825,7 @@ attribute-sets:`
`1816`	`1825`	`-`
`1817`	`1826`	`name: port`
`1818`	`1827`	`type: u16`
	`1828`	`+ byte-order: big-endian`
`1819`	`1829`	`-`
`1820`	`1830`	`name: collect-metadata`
`1821`	`1831`	`type: flag`
`@@ -1835,6 +1845,7 @@ attribute-sets:`
`1835`	`1845`	`-`
`1836`	`1846`	`name: label`
`1837`	`1847`	`type: u32`
	`1848`	`+ byte-order: big-endian`
`1838`	`1849`	`-`
`1839`	`1850`	`name: ttl-inherit`
`1840`	`1851`	`type: u8`
`@@ -1875,9 +1886,11 @@ attribute-sets:`
`1875`	`1886`	`-`
`1876`	`1887`	`name: flowinfo`
`1877`	`1888`	`type: u32`
	`1889`	`+ byte-order: big-endian`
`1878`	`1890`	`-`
`1879`	`1891`	`name: flags`
`1880`	`1892`	`type: u16`
	`1893`	`+ byte-order: big-endian`
`1881`	`1894`	`-`
`1882`	`1895`	`name: proto`
`1883`	`1896`	`type: u8`
`@@ -1907,9 +1920,11 @@ attribute-sets:`
`1907`	`1920`	`-`
`1908`	`1921`	`name: encap-sport`
`1909`	`1922`	`type: u16`
	`1923`	`+ byte-order: big-endian`
`1910`	`1924`	`-`
`1911`	`1925`	`name: encap-dport`
`1912`	`1926`	`type: u16`
	`1927`	`+ byte-order: big-endian`
`1913`	`1928`	`-`
`1914`	`1929`	`name: collect-metadata`
`1915`	`1930`	`type: flag`