Skip to content

Commit d551d2e

Browse files
committed
Merge tag 'drm-intel-fixes-2026-03-19' of https://gitlab.freedesktop.org/drm/i915/kernel into drm-fixes
- Fix #15771: Screen corruption and stuttering on P14s w/ 3K display - Fix for PSR entry setup frames count on rejected commit - Fix OOPS if firmware is not loaded and suspend is attempted - Fix unlikely NULL deref due to DC6 on probe Signed-off-by: Dave Airlie <[email protected]> From: Joonas Lahtinen <[email protected]> Link: https://patch.msgid.link/abujAnD-lRDCVSKg@jlahtine-mobl
2 parents f338e77 + 0162ab3 commit d551d2e

5 files changed

Lines changed: 10 additions & 6 deletions

File tree

drivers/gpu/drm/i915/display/intel_display_power_well.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -806,7 +806,7 @@ void gen9_set_dc_state(struct intel_display *display, u32 state)
806806
power_domains->dc_state, val & mask);
807807

808808
enable_dc6 = state & DC_STATE_EN_UPTO_DC6;
809-
dc6_was_enabled = val & DC_STATE_EN_UPTO_DC6;
809+
dc6_was_enabled = power_domains->dc_state & DC_STATE_EN_UPTO_DC6;
810810
if (!dc6_was_enabled && enable_dc6)
811811
intel_dmc_update_dc6_allowed_count(display, true);
812812

drivers/gpu/drm/i915/display/intel_display_types.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1186,6 +1186,7 @@ struct intel_crtc_state {
11861186
u32 dc3co_exitline;
11871187
u16 su_y_granularity;
11881188
u8 active_non_psr_pipes;
1189+
u8 entry_setup_frames;
11891190
const char *no_psr_reason;
11901191

11911192
/*

drivers/gpu/drm/i915/display/intel_dmc.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,8 +1599,7 @@ static bool intel_dmc_get_dc6_allowed_count(struct intel_display *display, u32 *
15991599
return false;
16001600

16011601
mutex_lock(&power_domains->lock);
1602-
dc6_enabled = intel_de_read(display, DC_STATE_EN) &
1603-
DC_STATE_EN_UPTO_DC6;
1602+
dc6_enabled = power_domains->dc_state & DC_STATE_EN_UPTO_DC6;
16041603
if (dc6_enabled)
16051604
intel_dmc_update_dc6_allowed_count(display, false);
16061605

drivers/gpu/drm/i915/display/intel_psr.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1717,7 +1717,7 @@ static bool _psr_compute_config(struct intel_dp *intel_dp,
17171717
entry_setup_frames = intel_psr_entry_setup_frames(intel_dp, conn_state, adjusted_mode);
17181718

17191719
if (entry_setup_frames >= 0) {
1720-
intel_dp->psr.entry_setup_frames = entry_setup_frames;
1720+
crtc_state->entry_setup_frames = entry_setup_frames;
17211721
} else {
17221722
crtc_state->no_psr_reason = "PSR setup timing not met";
17231723
drm_dbg_kms(display->drm,
@@ -1815,7 +1815,7 @@ static bool intel_psr_needs_wa_18037818876(struct intel_dp *intel_dp,
18151815
{
18161816
struct intel_display *display = to_intel_display(intel_dp);
18171817

1818-
return (DISPLAY_VER(display) == 20 && intel_dp->psr.entry_setup_frames > 0 &&
1818+
return (DISPLAY_VER(display) == 20 && crtc_state->entry_setup_frames > 0 &&
18191819
!crtc_state->has_sel_update);
18201820
}
18211821

@@ -2189,6 +2189,7 @@ static void intel_psr_enable_locked(struct intel_dp *intel_dp,
21892189
intel_dp->psr.pkg_c_latency_used = crtc_state->pkg_c_latency_used;
21902190
intel_dp->psr.io_wake_lines = crtc_state->alpm_state.io_wake_lines;
21912191
intel_dp->psr.fast_wake_lines = crtc_state->alpm_state.fast_wake_lines;
2192+
intel_dp->psr.entry_setup_frames = crtc_state->entry_setup_frames;
21922193

21932194
if (!psr_interrupt_error_check(intel_dp))
21942195
return;
@@ -3109,6 +3110,8 @@ void intel_psr_pre_plane_update(struct intel_atomic_state *state,
31093110
* - Display WA #1136: skl, bxt
31103111
*/
31113112
if (intel_crtc_needs_modeset(new_crtc_state) ||
3113+
new_crtc_state->update_m_n ||
3114+
new_crtc_state->update_lrr ||
31123115
!new_crtc_state->has_psr ||
31133116
!new_crtc_state->active_planes ||
31143117
new_crtc_state->has_sel_update != psr->sel_update_enabled ||

drivers/gpu/drm/i915/gt/intel_engine_cs.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1967,7 +1967,8 @@ void intel_engines_reset_default_submission(struct intel_gt *gt)
19671967
if (engine->sanitize)
19681968
engine->sanitize(engine);
19691969

1970-
engine->set_default_submission(engine);
1970+
if (engine->set_default_submission)
1971+
engine->set_default_submission(engine);
19711972
}
19721973
}
19731974

0 commit comments

Comments
 (0)