Skip to content

Commit d3922f6

Browse files
zhijianli88rleon
authored andcommitted
RDMA/rxe: Remove unused page_offset member
In rxe_map_mr_sg(), the `page_offset` member of the `rxe_mr` struct was initialized based on `ibmr.iova`, which will be updated inside ib_sg_to_pages() later. Consequently, the value assigned to `page_offset` was incorrect. However, since `page_offset` was never utilized throughout the code, it can be safely removed to clean up the codebase and avoid future confusion. Signed-off-by: Li Zhijian <[email protected]> Link: https://patch.msgid.link/[email protected] Reviewed-by: Zhu Yanjun <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]>
1 parent 18ea78e commit d3922f6

3 files changed

Lines changed: 0 additions & 3 deletions

File tree

drivers/infiniband/sw/rxe/rxe_mr.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,6 @@ int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sgl,
237237
mr->nbuf = 0;
238238
mr->page_shift = ilog2(page_size);
239239
mr->page_mask = ~((u64)page_size - 1);
240-
mr->page_offset = mr->ibmr.iova & (page_size - 1);
241240

242241
return ib_sg_to_pages(ibmr, sgl, sg_nents, sg_offset, rxe_set_page);
243242
}

drivers/infiniband/sw/rxe/rxe_odp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,6 @@ int rxe_odp_mr_init_user(struct rxe_dev *rxe, u64 start, u64 length,
110110
mr->access = access_flags;
111111
mr->ibmr.length = length;
112112
mr->ibmr.iova = iova;
113-
mr->page_offset = ib_umem_offset(&umem_odp->umem);
114113

115114
err = rxe_odp_init_pages(mr);
116115
if (err) {

drivers/infiniband/sw/rxe/rxe_verbs.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,6 @@ struct rxe_mr {
347347
int access;
348348
atomic_t num_mw;
349349

350-
unsigned int page_offset;
351350
unsigned int page_shift;
352351
u64 page_mask;
353352

0 commit comments

Comments
 (0)