Skip to content

Commit c1ed856

Browse files
ShuichengLinThomas Hellström
authored andcommitted
drm/xe/configfs: Fix is_bound() pci_dev lifetime
Move pci_dev_put() after pci_dbg() to avoid using pdev after dropping its reference. Fixes: 2674f1e ("drm/xe/configfs: Block runtime attribute changes") Signed-off-by: Shuicheng Lin <[email protected]> Reviewed-by: Ashutosh Dixit <[email protected]> Signed-off-by: Ashutosh Dixit <[email protected]> Link: https://patch.msgid.link/[email protected] (cherry picked from commit 63b3360) Signed-off-by: Thomas Hellström <[email protected]>
1 parent ca8dcfe commit c1ed856

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/gpu/drm/xe/xe_configfs.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,11 +347,10 @@ static bool is_bound(struct xe_config_group_device *dev)
347347
return false;
348348

349349
ret = pci_get_drvdata(pdev);
350-
pci_dev_put(pdev);
351-
352350
if (ret)
353351
pci_dbg(pdev, "Already bound to driver\n");
354352

353+
pci_dev_put(pdev);
355354
return ret;
356355
}
357356

0 commit comments

Comments
 (0)