Skip to content

Commit a4c2b8b

Browse files
edumazetkuba-moo
authored andcommitted
net_sched: sch_fq: clear q->band_pkt_count[] in fq_reset()
When/if a NIC resets, queues are deactivated by dev_deactivate_many(), then reactivated when the reset operation completes. fq_reset() removes all the skbs from various queues. If we do not clear q->band_pkt_count[], these counters keep growing and can eventually reach sch->limit, preventing new packets to be queued. Many thanks to Praveen for discovering the root cause. Fixes: 29f834a ("net_sched: sch_fq: add 3 bands and WRR scheduling") Diagnosed-by: Praveen Kaligineedi <[email protected]> Signed-off-by: Eric Dumazet <[email protected]> Reviewed-by: Neal Cardwell <[email protected]> Reviewed-by: Willem de Bruijn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent f7d92f1 commit a4c2b8b

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

net/sched/sch_fq.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -827,6 +827,7 @@ static void fq_reset(struct Qdisc *sch)
827827
for (idx = 0; idx < FQ_BANDS; idx++) {
828828
q->band_flows[idx].new_flows.first = NULL;
829829
q->band_flows[idx].old_flows.first = NULL;
830+
q->band_pkt_count[idx] = 0;
830831
}
831832
q->delayed = RB_ROOT;
832833
q->flows = 0;

0 commit comments

Comments
 (0)