Skip to content

Commit 98cf7df

Browse files
zenghongling0719hdeller
authored andcommitted
fbdev: omap2: fix inconsistent lock returns in omapfb_mmap
Fix the warning about inconsistent returns for '&rg->lock' in omapfb_mmap() function. The warning arises because the error path uses 'ofbi->region' while the normal path uses 'rg'. smatch warnings: drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1126 omapfb_mmap() warn: inconsistent returns '&rg->lock'. Reported-by: kernel test robot <[email protected]> Signed-off-by: Hongling Zeng <[email protected]> Signed-off-by: Helge Deller <[email protected]>
1 parent 3bea4a0 commit 98cf7df

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/video/fbdev/omap2/omapfb/omapfb-main.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1121,7 +1121,7 @@ static int omapfb_mmap(struct fb_info *fbi, struct vm_area_struct *vma)
11211121
return 0;
11221122

11231123
error:
1124-
omapfb_put_mem_region(ofbi->region);
1124+
omapfb_put_mem_region(rg);
11251125

11261126
return r;
11271127
}

0 commit comments

Comments
 (0)