Skip to content

Commit 8901ac9

Browse files
committed
printf: Compile the kunit test with DISABLE_BRANCH_PROFILING DISABLE_BRANCH_PROFILING
GCC < 12.1 can miscompile printf_kunit's errptr() test when branch profiling is enabled. BUILD_BUG_ON(IS_ERR(PTR)) is a constant false expression, but CONFIG_TRACE_BRANCH_PROFILING and CONFIG_PROFILE_ALL_BRANCHES make the IS_ERR() path side-effectful. GCC's IPA splitter can then outline the cold assert arm into errptr.part.* and leave that clone with an unconditional __compiletime_assert_*() call, causing a false build failure. This started showing up after test_hashed() became a macro and moved its local buffer into errptr(), which changed GCC's inlining and splitting decisions enough to expose the compiler bug. Workaround the problem by disabling the branch profiling for printf_kunit.o. It is a straightforward and acceptable solution. The workaround can be removed once the minimum GCC includes commit 76fe49423047 ("Fix tree-optimization/101941: IPA splitting out function with error attribute"), which first shipped in GCC 12.1. Fixes: 9bfa52d ("printf: convert test_hashed into macro") Reported-by: kernel test robot <[email protected]> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/ Cc: [email protected] Acked-by: Tamir Duberstein <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Petr Mladek <[email protected]>
1 parent 6de23f8 commit 8901ac9

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

lib/tests/Makefile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,8 @@ obj-$(CONFIG_MEMCPY_KUNIT_TEST) += memcpy_kunit.o
4040
obj-$(CONFIG_MIN_HEAP_KUNIT_TEST) += min_heap_kunit.o
4141
CFLAGS_overflow_kunit.o = $(call cc-disable-warning, tautological-constant-out-of-range-compare)
4242
obj-$(CONFIG_OVERFLOW_KUNIT_TEST) += overflow_kunit.o
43+
# GCC < 12.1 can miscompile errptr() test when branch profiling is enabled.
44+
CFLAGS_printf_kunit.o += -DDISABLE_BRANCH_PROFILING
4345
obj-$(CONFIG_PRINTF_KUNIT_TEST) += printf_kunit.o
4446
obj-$(CONFIG_RANDSTRUCT_KUNIT_TEST) += randstruct_kunit.o
4547
obj-$(CONFIG_SCANF_KUNIT_TEST) += scanf_kunit.o

0 commit comments

Comments
 (0)