Skip to content

Commit 87d1268

Browse files
Noltarikuba-moo
authored andcommitted
net: sfp: improve Huawei MA5671a fixup
With the current sfp_fixup_ignore_tx_fault() fixup we ignore the TX_FAULT signal, but we also need to apply sfp_fixup_ignore_los() in order to be able to communicate with the module even if the fiber isn't connected for configuration purposes. This is needed for all the MA5671a firmwares, excluding the FS modded firmware. Fixes: 2069624 ("net: sfp: Add tx-fault workaround for Huawei MA5671A SFP ONT") Signed-off-by: Álvaro Fernández Rojas <[email protected]> Reviewed-by: Andrew Lunn <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent c113d5e commit 87d1268

1 file changed

Lines changed: 7 additions & 1 deletion

File tree

drivers/net/phy/sfp.c

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,6 +367,12 @@ static void sfp_fixup_ignore_tx_fault(struct sfp *sfp)
367367
sfp->state_ignore_mask |= SFP_F_TX_FAULT;
368368
}
369369

370+
static void sfp_fixup_ignore_tx_fault_and_los(struct sfp *sfp)
371+
{
372+
sfp_fixup_ignore_tx_fault(sfp);
373+
sfp_fixup_ignore_los(sfp);
374+
}
375+
370376
static void sfp_fixup_ignore_hw(struct sfp *sfp, unsigned int mask)
371377
{
372378
sfp->state_hw_mask &= ~mask;
@@ -530,7 +536,7 @@ static const struct sfp_quirk sfp_quirks[] = {
530536
// Huawei MA5671A can operate at 2500base-X, but report 1.2GBd NRZ in
531537
// their EEPROM
532538
SFP_QUIRK("HUAWEI", "MA5671A", sfp_quirk_2500basex,
533-
sfp_fixup_ignore_tx_fault),
539+
sfp_fixup_ignore_tx_fault_and_los),
534540

535541
// Lantech 8330-262D-E and 8330-265D can operate at 2500base-X, but
536542
// incorrectly report 2500MBd NRZ in their EEPROM.

0 commit comments

Comments
 (0)