Commit 82b9150
tick/nohz: Fix inverted return value in check_tick_dependency() fast path
Commit 5653467 ("tick/nohz: Optimize check_tick_dependency() with
early return") added a fast path that returns !val when the tick_stop
tracepoint is disabled.
This is inverted: the slow path returns true when a dependency IS found
(val != 0), but !val returns true when val is zero (no dependency). The
result is that can_stop_full_tick() sees "dependency found" when there are
none, and the tick never stops on nohz_full CPUs.
Fix this by returning !!val instead of !val, matching the slow-path semantics.
Fixes: 5653467 ("tick/nohz: Optimize check_tick_dependency() with early return")
Signed-off-by: Josh Snyder <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Assisted-by: Claude:claude-opus-4-6
Link: https://patch.msgid.link/[email protected]1 parent 591cd65 commit 82b9150
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
348 | | - | |
| 348 | + | |
349 | 349 | | |
350 | 350 | | |
351 | 351 | | |
| |||
0 commit comments