fs/ntfs3: fix Smatch warnings

aalexandrovich · aalexandrovich · commit 819bd270abf9 · 2026-04-16T10:28:32.000+02:00
Initialize err in ni_allocate_da_blocks_locked() and correct the
pre_alloc condition in attr_allocate_clusters().

Suggested-by: Dan Carpenter &lt;error27@gmail.com&gt;
Signed-off-by: Konstantin Komarov &lt;almaz.alexandrovich@paragon-software.com&gt;
diff --git a/fs/ntfs3/attrib.c b/fs/ntfs3/attrib.c
@@ -173,7 +173,7 @@ int attr_allocate_clusters(struct ntfs_sb_info *sbi, struct runs_tree *run,
 
 		if (err == -ENOSPC && pre) {
 			pre = 0;
-			if (*pre_alloc)
+			if (pre_alloc)
 				*pre_alloc = 0;
 			continue;
 		}
diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c
@@ -3267,7 +3267,7 @@ int ni_allocate_da_blocks(struct ntfs_inode *ni)
  */
 int ni_allocate_da_blocks_locked(struct ntfs_inode *ni)
 {
-	int err;
+	int err = 0;
 
 	if (!ni->file.run_da.count)
 		return 0;

Original file line number	Diff line number	Diff line change
`@@ -173,7 +173,7 @@ int attr_allocate_clusters(struct ntfs_sb_info sbi, struct runs_tree run,`
`173`	`173`
`174`	`174`	`if (err == -ENOSPC && pre) {`
`175`	`175`	`pre = 0;`
`176`		`- if (*pre_alloc)`
	`176`	`+ if (pre_alloc)`
`177`	`177`	`*pre_alloc = 0;`
`178`	`178`	`continue;`
`179`	`179`	`}`
Original file line number	Diff line number	Diff line change
`@@ -3267,7 +3267,7 @@ int ni_allocate_da_blocks(struct ntfs_inode *ni)`
`3267`	`3267`	`*/`
`3268`	`3268`	`int ni_allocate_da_blocks_locked(struct ntfs_inode *ni)`
`3269`	`3269`	`{`
`3270`		`- int err;`
	`3270`	`+ int err = 0;`
`3271`	`3271`
`3272`	`3272`	`if (!ni->file.run_da.count)`
`3273`	`3273`	`return 0;`