Skip to content

Commit 7a9f448

Browse files
gregkhmartinkpetersen
authored andcommitted
scsi: ses: Handle positive SCSI error from ses_recv_diag()
ses_recv_diag() can return a positive value, which also means that an error happened, so do not only test for negative values. Cc: James E.J. Bottomley <[email protected]> Cc: Martin K. Petersen <[email protected]> Cc: stable <[email protected]> Assisted-by: gkh_clanker_2000 Signed-off-by: Greg Kroah-Hartman <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Link: https://patch.msgid.link/2026022301-bony-overstock-a07f@gregkh Signed-off-by: Martin K. Petersen <[email protected]>
1 parent 8ddc0c2 commit 7a9f448

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/scsi/ses.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ static unsigned char *ses_get_page2_descriptor(struct enclosure_device *edev,
215215
unsigned char *type_ptr = ses_dev->page1_types;
216216
unsigned char *desc_ptr = ses_dev->page2 + 8;
217217

218-
if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len) < 0)
218+
if (ses_recv_diag(sdev, 2, ses_dev->page2, ses_dev->page2_len))
219219
return NULL;
220220

221221
for (i = 0; i < ses_dev->page1_num_types; i++, type_ptr += 4) {

0 commit comments

Comments
 (0)