Skip to content

Commit 6f9674a

Browse files
AnsuelLinus Walleij
authored andcommitted
pinctrl: airoha: fix wrong PHY LED mux value for LED1 GPIO46
In all the MUX value for LED1 GPIO46 there is a Copy-Paste error where the MUX value is set to LED0_MODE_MASK instead of LED1_MODE_MASK. This wasn't notice as there were no board that made use of the secondary PHY LED but looking at the internal Documentation the actual value should be LED1_MODE_MASK similar to the other GPIO entry. Fix the wrong value to apply the correct MUX configuration. Cc: [email protected] Fixes: 1c8ace2 ("pinctrl: airoha: Add support for EN7581 SoC") Signed-off-by: Christian Marangi <[email protected]> Acked-by: Lorenzo Bianconi <[email protected]> Signed-off-by: Linus Walleij <[email protected]>
1 parent 76eeb9b commit 6f9674a

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

drivers/pinctrl/mediatek/pinctrl-airoha.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1752,8 +1752,8 @@ static const struct airoha_pinctrl_func_group phy1_led1_func_group[] = {
17521752
.regmap[0] = {
17531753
AIROHA_FUNC_MUX,
17541754
REG_GPIO_2ND_I2C_MODE,
1755-
GPIO_LAN3_LED0_MODE_MASK,
1756-
GPIO_LAN3_LED0_MODE_MASK
1755+
GPIO_LAN3_LED1_MODE_MASK,
1756+
GPIO_LAN3_LED1_MODE_MASK
17571757
},
17581758
.regmap[1] = {
17591759
AIROHA_FUNC_MUX,
@@ -1816,8 +1816,8 @@ static const struct airoha_pinctrl_func_group phy2_led1_func_group[] = {
18161816
.regmap[0] = {
18171817
AIROHA_FUNC_MUX,
18181818
REG_GPIO_2ND_I2C_MODE,
1819-
GPIO_LAN3_LED0_MODE_MASK,
1820-
GPIO_LAN3_LED0_MODE_MASK
1819+
GPIO_LAN3_LED1_MODE_MASK,
1820+
GPIO_LAN3_LED1_MODE_MASK
18211821
},
18221822
.regmap[1] = {
18231823
AIROHA_FUNC_MUX,
@@ -1880,8 +1880,8 @@ static const struct airoha_pinctrl_func_group phy3_led1_func_group[] = {
18801880
.regmap[0] = {
18811881
AIROHA_FUNC_MUX,
18821882
REG_GPIO_2ND_I2C_MODE,
1883-
GPIO_LAN3_LED0_MODE_MASK,
1884-
GPIO_LAN3_LED0_MODE_MASK
1883+
GPIO_LAN3_LED1_MODE_MASK,
1884+
GPIO_LAN3_LED1_MODE_MASK
18851885
},
18861886
.regmap[1] = {
18871887
AIROHA_FUNC_MUX,
@@ -1944,8 +1944,8 @@ static const struct airoha_pinctrl_func_group phy4_led1_func_group[] = {
19441944
.regmap[0] = {
19451945
AIROHA_FUNC_MUX,
19461946
REG_GPIO_2ND_I2C_MODE,
1947-
GPIO_LAN3_LED0_MODE_MASK,
1948-
GPIO_LAN3_LED0_MODE_MASK
1947+
GPIO_LAN3_LED1_MODE_MASK,
1948+
GPIO_LAN3_LED1_MODE_MASK
19491949
},
19501950
.regmap[1] = {
19511951
AIROHA_FUNC_MUX,

0 commit comments

Comments
 (0)