Skip to content

Commit 6879ef1

Browse files
mrutland-armctmarinas
authored andcommitted
arm64: entry: Consistently prefix arm64-specific wrappers
For historical reasons, arm64's entry code has arm64-specific functions named enter_from_kernel_mode() and exit_to_kernel_mode(), which are wrappers for similarly-named functions from the generic irqentry code. Other arm64-specific wrappers have an 'arm64_' prefix to clearly distinguish them from their generic counterparts, e.g. arm64_enter_from_user_mode() and arm64_exit_to_user_mode(). For consistency and clarity, add an 'arm64_' prefix to these functions. There should be no functional change as a result of this patch. Signed-off-by: Mark Rutland <[email protected]> Cc: Andy Lutomirski <[email protected]> Cc: Jinjie Ruan <[email protected]> Cc: Peter Zijlstra <[email protected]> Cc: Thomas Gleixner <[email protected]> Cc: Vladimir Murzin <[email protected]> Cc: Will Deacon <[email protected]> Reviewed-by: Jinjie Ruan <[email protected]> Acked-by: Peter Zijlstra (Intel) <[email protected]> Signed-off-by: Catalin Marinas <[email protected]>
1 parent 2371bd8 commit 6879ef1

1 file changed

Lines changed: 19 additions & 19 deletions

File tree

arch/arm64/kernel/entry-common.c

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
* Before this function is called it is not safe to call regular kernel code,
3636
* instrumentable code, or any code which may trigger an exception.
3737
*/
38-
static noinstr irqentry_state_t enter_from_kernel_mode(struct pt_regs *regs)
38+
static noinstr irqentry_state_t arm64_enter_from_kernel_mode(struct pt_regs *regs)
3939
{
4040
irqentry_state_t state;
4141

@@ -51,8 +51,8 @@ static noinstr irqentry_state_t enter_from_kernel_mode(struct pt_regs *regs)
5151
* After this function returns it is not safe to call regular kernel code,
5252
* instrumentable code, or any code which may trigger an exception.
5353
*/
54-
static void noinstr exit_to_kernel_mode(struct pt_regs *regs,
55-
irqentry_state_t state)
54+
static void noinstr arm64_exit_to_kernel_mode(struct pt_regs *regs,
55+
irqentry_state_t state)
5656
{
5757
mte_check_tfsr_exit();
5858
irqentry_exit(regs, state);
@@ -298,67 +298,67 @@ static void noinstr el1_abort(struct pt_regs *regs, unsigned long esr)
298298
unsigned long far = read_sysreg(far_el1);
299299
irqentry_state_t state;
300300

301-
state = enter_from_kernel_mode(regs);
301+
state = arm64_enter_from_kernel_mode(regs);
302302
local_daif_inherit(regs);
303303
do_mem_abort(far, esr, regs);
304304
local_daif_mask();
305-
exit_to_kernel_mode(regs, state);
305+
arm64_exit_to_kernel_mode(regs, state);
306306
}
307307

308308
static void noinstr el1_pc(struct pt_regs *regs, unsigned long esr)
309309
{
310310
unsigned long far = read_sysreg(far_el1);
311311
irqentry_state_t state;
312312

313-
state = enter_from_kernel_mode(regs);
313+
state = arm64_enter_from_kernel_mode(regs);
314314
local_daif_inherit(regs);
315315
do_sp_pc_abort(far, esr, regs);
316316
local_daif_mask();
317-
exit_to_kernel_mode(regs, state);
317+
arm64_exit_to_kernel_mode(regs, state);
318318
}
319319

320320
static void noinstr el1_undef(struct pt_regs *regs, unsigned long esr)
321321
{
322322
irqentry_state_t state;
323323

324-
state = enter_from_kernel_mode(regs);
324+
state = arm64_enter_from_kernel_mode(regs);
325325
local_daif_inherit(regs);
326326
do_el1_undef(regs, esr);
327327
local_daif_mask();
328-
exit_to_kernel_mode(regs, state);
328+
arm64_exit_to_kernel_mode(regs, state);
329329
}
330330

331331
static void noinstr el1_bti(struct pt_regs *regs, unsigned long esr)
332332
{
333333
irqentry_state_t state;
334334

335-
state = enter_from_kernel_mode(regs);
335+
state = arm64_enter_from_kernel_mode(regs);
336336
local_daif_inherit(regs);
337337
do_el1_bti(regs, esr);
338338
local_daif_mask();
339-
exit_to_kernel_mode(regs, state);
339+
arm64_exit_to_kernel_mode(regs, state);
340340
}
341341

342342
static void noinstr el1_gcs(struct pt_regs *regs, unsigned long esr)
343343
{
344344
irqentry_state_t state;
345345

346-
state = enter_from_kernel_mode(regs);
346+
state = arm64_enter_from_kernel_mode(regs);
347347
local_daif_inherit(regs);
348348
do_el1_gcs(regs, esr);
349349
local_daif_mask();
350-
exit_to_kernel_mode(regs, state);
350+
arm64_exit_to_kernel_mode(regs, state);
351351
}
352352

353353
static void noinstr el1_mops(struct pt_regs *regs, unsigned long esr)
354354
{
355355
irqentry_state_t state;
356356

357-
state = enter_from_kernel_mode(regs);
357+
state = arm64_enter_from_kernel_mode(regs);
358358
local_daif_inherit(regs);
359359
do_el1_mops(regs, esr);
360360
local_daif_mask();
361-
exit_to_kernel_mode(regs, state);
361+
arm64_exit_to_kernel_mode(regs, state);
362362
}
363363

364364
static void noinstr el1_breakpt(struct pt_regs *regs, unsigned long esr)
@@ -420,11 +420,11 @@ static void noinstr el1_fpac(struct pt_regs *regs, unsigned long esr)
420420
{
421421
irqentry_state_t state;
422422

423-
state = enter_from_kernel_mode(regs);
423+
state = arm64_enter_from_kernel_mode(regs);
424424
local_daif_inherit(regs);
425425
do_el1_fpac(regs, esr);
426426
local_daif_mask();
427-
exit_to_kernel_mode(regs, state);
427+
arm64_exit_to_kernel_mode(regs, state);
428428
}
429429

430430
asmlinkage void noinstr el1h_64_sync_handler(struct pt_regs *regs)
@@ -491,13 +491,13 @@ static __always_inline void __el1_irq(struct pt_regs *regs,
491491
{
492492
irqentry_state_t state;
493493

494-
state = enter_from_kernel_mode(regs);
494+
state = arm64_enter_from_kernel_mode(regs);
495495

496496
irq_enter_rcu();
497497
do_interrupt_handler(regs, handler);
498498
irq_exit_rcu();
499499

500-
exit_to_kernel_mode(regs, state);
500+
arm64_exit_to_kernel_mode(regs, state);
501501
}
502502
static void noinstr el1_interrupt(struct pt_regs *regs,
503503
void (*handler)(struct pt_regs *))

0 commit comments

Comments
 (0)