Skip to content

Commit 68230aa

Browse files
Waiman-Longhtejun
authored andcommitted
cgroup/cpuset: Fix incorrect use of cpuset_update_tasks_cpumask() in update_cpumasks_hier()
Commit e2ffe50 ("cgroup/cpuset: Add cpuset.cpus.exclusive for v2") incorrectly changed the 2nd parameter of cpuset_update_tasks_cpumask() from tmp->new_cpus to cp->effective_cpus. This second parameter is just a temporary cpumask for internal use. The cpuset_update_tasks_cpumask() function was originally called update_tasks_cpumask() before commit 381b53c ("cgroup/cpuset: rename functions shared between v1 and v2"). This mistake can incorrectly change the effective_cpus of the cpuset when it is the top_cpuset or in arm64 architecture where task_cpu_possible_mask() may differ from cpu_possible_mask. So far top_cpuset hasn't been passed to update_cpumasks_hier() yet, but arm64 arch can still be impacted. Fix it by reverting the incorrect change. Fixes: e2ffe50 ("cgroup/cpuset: Add cpuset.cpus.exclusive for v2") Signed-off-by: Waiman Long <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent f9a1767 commit 68230aa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/cgroup/cpuset.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2157,7 +2157,7 @@ static void update_cpumasks_hier(struct cpuset *cs, struct tmpmasks *tmp,
21572157
WARN_ON(!is_in_v2_mode() &&
21582158
!cpumask_equal(cp->cpus_allowed, cp->effective_cpus));
21592159

2160-
cpuset_update_tasks_cpumask(cp, cp->effective_cpus);
2160+
cpuset_update_tasks_cpumask(cp, tmp->new_cpus);
21612161

21622162
/*
21632163
* On default hierarchy, inherit the CS_SCHED_LOAD_BALANCE

0 commit comments

Comments
 (0)