Skip to content

Commit 5f9ad16

Browse files
tyhicksbrauner
authored andcommitted
ecryptfs: Fix improper mknod pairing of start_creating()/end_removing()
The ecryptfs_start_creating_dentry() function must be paired with the end_creating() function. Fix ecryptfs_mknod() so that end_creating() is properly called in the return path, instead of end_removing(). Fixes: f046fbb ("ecryptfs: use new start_creating/start_removing APIs") Signed-off-by: Tyler Hicks <[email protected]> Link: https://patch.msgid.link/[email protected] Reviewed-by: Amir Goldstein <[email protected]> Signed-off-by: Christian Brauner <[email protected]>
1 parent 3dd57dd commit 5f9ad16

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/ecryptfs/inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -584,7 +584,7 @@ ecryptfs_mknod(struct mnt_idmap *idmap, struct inode *dir,
584584
fsstack_copy_attr_times(dir, lower_dir);
585585
fsstack_copy_inode_size(dir, lower_dir);
586586
out:
587-
end_removing(lower_dentry);
587+
end_creating(lower_dentry);
588588
if (d_really_is_negative(dentry))
589589
d_drop(dentry);
590590
return rc;

0 commit comments

Comments
 (0)