Skip to content

Commit 5f25805

Browse files
author
Vasily Gorbik
committed
s390/xor: Fix xor_xc_5() inline assembly
xor_xc_5() contains a larl 1,2f that is not used by the asm and is not declared as a clobber. This can corrupt a compiler-allocated value in %r1 and lead to miscompilation. Remove the instruction. Fixes: 745600e ("s390/lib: Use exrl instead of ex in xor functions") Cc: [email protected] Reviewed-by: Juergen Christ <[email protected]> Reviewed-by: Heiko Carstens <[email protected]> Reviewed-by: Sven Schnelle <[email protected]> Signed-off-by: Vasily Gorbik <[email protected]>
1 parent 11439c4 commit 5f25805

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

arch/s390/lib/xor.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ static void xor_xc_5(unsigned long bytes, unsigned long * __restrict p1,
9696
const unsigned long * __restrict p5)
9797
{
9898
asm volatile(
99-
" larl 1,2f\n"
10099
" aghi %0,-1\n"
101100
" jm 6f\n"
102101
" srlg 0,%0,8\n"

0 commit comments

Comments
 (0)