ublk: optimize ublk_rq_has_data()

calebsander · kawasaki · commit 5dae3cf25b15 · 2026-04-24T16:55:09.000+09:00
ublk_rq_has_data() currently uses bio_has_data(), which involves 2
indirections and several branches. Use blk_rq_bytes() instead, which
performs a single indirection with no branches.

Signed-off-by: Caleb Sander Mateos &lt;csander@purestorage.com&gt;
diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c
@@ -1174,7 +1174,7 @@ static inline struct ublk_queue *ublk_get_queue(struct ublk_device *dev,
 
 static inline bool ublk_rq_has_data(const struct request *rq)
 {
-	return bio_has_data(rq->bio);
+	return blk_rq_bytes(rq);
 }
 
 static inline struct ublksrv_io_desc *

Original file line number	Diff line number	Diff line change
`@@ -1174,7 +1174,7 @@ static inline struct ublk_queue ublk_get_queue(struct ublk_device dev,`
`1174`	`1174`
`1175`	`1175`	`static inline bool ublk_rq_has_data(const struct request *rq)`
`1176`	`1176`	`{`
`1177`		`- return bio_has_data(rq->bio);`
	`1177`	`+ return blk_rq_bytes(rq);`
`1178`	`1178`	`}`
`1179`	`1179`
`1180`	`1180`	`static inline struct ublksrv_io_desc *`