Skip to content

Commit 5a58ac9

Browse files
maurizio-lombardiChristoph Hellwig
authored andcommitted
nvme-tcp: log TLS handshake failures at error level
Update the nvme_tcp_start_tls() function to use dev_err() instead of dev_dbg() when a TLS error is detected. This ensures that handshake failures are visible by default, aiding in debugging. Signed-off-by: Maurizio Lombardi <[email protected]> Reviewed-by: Laurence Oberman <[email protected]> Reviewed-by: Hannes Reinecke <[email protected]> Signed-off-by: Christoph Hellwig <[email protected]>
1 parent 3be8ad8 commit 5a58ac9

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

drivers/nvme/host/tcp.c

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1745,9 +1745,14 @@ static int nvme_tcp_start_tls(struct nvme_ctrl *nctrl,
17451745
qid, ret);
17461746
tls_handshake_cancel(queue->sock->sk);
17471747
} else {
1748-
dev_dbg(nctrl->device,
1749-
"queue %d: TLS handshake complete, error %d\n",
1750-
qid, queue->tls_err);
1748+
if (queue->tls_err) {
1749+
dev_err(nctrl->device,
1750+
"queue %d: TLS handshake complete, error %d\n",
1751+
qid, queue->tls_err);
1752+
} else {
1753+
dev_dbg(nctrl->device,
1754+
"queue %d: TLS handshake complete\n", qid);
1755+
}
17511756
ret = queue->tls_err;
17521757
}
17531758
return ret;

0 commit comments

Comments
 (0)