Skip to content

Commit 5a569ef

Browse files
hogandertursulin
authored andcommitted
drm/i915/display: Set C10_VDR_CTRL_MSGBUS_ACCESS before phy reg read
According to C10 VDR Register programming sequence we need set C10_VDR_CTRL_MSGBUS_ACCESS before accessing PHY internal registers from MsgBus. v2: set C10_VDR_CTRL_MSGBUS_ACCESS once for all owned lanes Bspec: 68962 Fixes: 9dc6196 ("drm/i915/display: Add function to configure LFPS sending") Suggested-by: Gustavo Sousa <[email protected]> Signed-off-by: Jouni Högander <[email protected]> Reviewed-by: Gustavo Sousa <[email protected]> Link: https://lore.kernel.org/r/[email protected] (cherry picked from commit 8921dce) Signed-off-by: Tvrtko Ursulin <[email protected]>
1 parent 3eb6357 commit 5a569ef

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/gpu/drm/i915/display/intel_cx0_phy.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3251,6 +3251,10 @@ void intel_lnl_mac_transmit_lfps(struct intel_encoder *encoder,
32513251

32523252
wakeref = intel_cx0_phy_transaction_begin(encoder);
32533253

3254+
if (intel_encoder_is_c10phy(encoder))
3255+
intel_cx0_rmw(encoder, owned_lane_mask, PHY_C10_VDR_CONTROL(1), 0,
3256+
C10_VDR_CTRL_MSGBUS_ACCESS, MB_WRITE_COMMITTED);
3257+
32543258
for (i = 0; i < 4; i++) {
32553259
int tx = i % 2 + 1;
32563260
u8 lane_mask = i < 2 ? INTEL_CX0_LANE0 : INTEL_CX0_LANE1;

0 commit comments

Comments
 (0)