Skip to content

Commit 599b4e2

Browse files
rddunlapakpm00
authored andcommitted
mm/mmu_notifier: clean up mmu_notifier.h kernel-doc
Eliminate kernel-doc warnings in mmu_notifier.h: - add a missing struct short description - use the correct format for function parameters - add missing function return comment sections Warning: include/linux/mmu_notifier.h:236 missing initial short description on line: * struct mmu_interval_notifier_ops Warning: include/linux/mmu_notifier.h:325 function parameter 'interval_sub' not described in 'mmu_interval_set_seq' Warning: include/linux/mmu_notifier.h:325 function parameter 'cur_seq' not described in 'mmu_interval_set_seq' Warning: include/linux/mmu_notifier.h:346 function parameter 'interval_sub' not described in 'mmu_interval_read_retry' Warning: include/linux/mmu_notifier.h:346 function parameter 'seq' not described in 'mmu_interval_read_retry' Warning: include/linux/mmu_notifier.h:346 No description found for return value of 'mmu_interval_read_retry' Warning: include/linux/mmu_notifier.h:370 function parameter 'interval_sub' not described in 'mmu_interval_check_retry' Warning: include/linux/mmu_notifier.h:370 function parameter 'seq' not described in 'mmu_interval_check_retry' Warning: include/linux/mmu_notifier.h:370 No description found for return value of 'mmu_interval_check_retry' Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Randy Dunlap <[email protected]> Reviewed-by: Jason Gunthorpe <[email protected]> Cc: David Hildenbrand <[email protected]> Cc: "Liam R. Howlett" <[email protected]> Cc: Lorenzo Stoakes <[email protected]> Cc: Michal Hocko <[email protected]> Cc: Mike Rapoport <[email protected]> Cc: Randy Dunlap <[email protected]> Cc: Suren Baghdasaryan <[email protected]> Cc: Vlastimil Babka <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent 7392f8e commit 599b4e2

1 file changed

Lines changed: 16 additions & 15 deletions

File tree

include/linux/mmu_notifier.h

Lines changed: 16 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ struct mmu_notifier {
234234
};
235235

236236
/**
237-
* struct mmu_interval_notifier_ops
237+
* struct mmu_interval_notifier_ops - callback for range notification
238238
* @invalidate: Upon return the caller must stop using any SPTEs within this
239239
* range. This function can sleep. Return false only if sleeping
240240
* was required but mmu_notifier_range_blockable(range) is false.
@@ -309,8 +309,8 @@ void mmu_interval_notifier_remove(struct mmu_interval_notifier *interval_sub);
309309

310310
/**
311311
* mmu_interval_set_seq - Save the invalidation sequence
312-
* @interval_sub - The subscription passed to invalidate
313-
* @cur_seq - The cur_seq passed to the invalidate() callback
312+
* @interval_sub: The subscription passed to invalidate
313+
* @cur_seq: The cur_seq passed to the invalidate() callback
314314
*
315315
* This must be called unconditionally from the invalidate callback of a
316316
* struct mmu_interval_notifier_ops under the same lock that is used to call
@@ -329,16 +329,16 @@ mmu_interval_set_seq(struct mmu_interval_notifier *interval_sub,
329329

330330
/**
331331
* mmu_interval_read_retry - End a read side critical section against a VA range
332-
* interval_sub: The subscription
333-
* seq: The return of the paired mmu_interval_read_begin()
332+
* @interval_sub: The subscription
333+
* @seq: The return of the paired mmu_interval_read_begin()
334334
*
335335
* This MUST be called under a user provided lock that is also held
336336
* unconditionally by op->invalidate() when it calls mmu_interval_set_seq().
337337
*
338338
* Each call should be paired with a single mmu_interval_read_begin() and
339339
* should be used to conclude the read side.
340340
*
341-
* Returns true if an invalidation collided with this critical section, and
341+
* Returns: true if an invalidation collided with this critical section, and
342342
* the caller should retry.
343343
*/
344344
static inline bool
@@ -350,20 +350,21 @@ mmu_interval_read_retry(struct mmu_interval_notifier *interval_sub,
350350

351351
/**
352352
* mmu_interval_check_retry - Test if a collision has occurred
353-
* interval_sub: The subscription
354-
* seq: The return of the matching mmu_interval_read_begin()
353+
* @interval_sub: The subscription
354+
* @seq: The return of the matching mmu_interval_read_begin()
355355
*
356356
* This can be used in the critical section between mmu_interval_read_begin()
357-
* and mmu_interval_read_retry(). A return of true indicates an invalidation
358-
* has collided with this critical region and a future
359-
* mmu_interval_read_retry() will return true.
360-
*
361-
* False is not reliable and only suggests a collision may not have
362-
* occurred. It can be called many times and does not have to hold the user
363-
* provided lock.
357+
* and mmu_interval_read_retry().
364358
*
365359
* This call can be used as part of loops and other expensive operations to
366360
* expedite a retry.
361+
* It can be called many times and does not have to hold the user
362+
* provided lock.
363+
*
364+
* Returns: true indicates an invalidation has collided with this critical
365+
* region and a future mmu_interval_read_retry() will return true.
366+
* False is not reliable and only suggests a collision may not have
367+
* occurred.
367368
*/
368369
static inline bool
369370
mmu_interval_check_retry(struct mmu_interval_notifier *interval_sub,

0 commit comments

Comments
 (0)