Skip to content

Commit 49d78ad

Browse files
committed
sched_ext: Drop spurious warning on kick during scheduler disable
kick_cpus_irq_workfn() warns when scx_kick_syncs is NULL, but this can legitimately happen when a BPF timer or other kick source races with free_kick_syncs() during scheduler disable. Drop the pr_warn_once() and add a comment explaining the race. Signed-off-by: Tejun Heo <[email protected]> Reviewed-by: Zhao Mengmeng <[email protected]>
1 parent e719e17 commit 49d78ad

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

kernel/sched/ext.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7600,10 +7600,9 @@ static void kick_cpus_irq_workfn(struct irq_work *irq_work)
76007600
unsigned long *ksyncs;
76017601
s32 cpu;
76027602

7603-
if (unlikely(!ksyncs_pcpu)) {
7604-
pr_warn_once("kick_cpus_irq_workfn() called with NULL scx_kick_syncs");
7603+
/* can race with free_kick_syncs() during scheduler disable */
7604+
if (unlikely(!ksyncs_pcpu))
76057605
return;
7606-
}
76077606

76087607
ksyncs = rcu_dereference_bh(ksyncs_pcpu)->syncs;
76097608

0 commit comments

Comments
 (0)