Skip to content

Commit 3d553be

Browse files
DispatchCodekeithbusch
authored andcommitted
nvmet: replace use of system_wq with system_percpu_wq
This patch continues the effort to refactor workqueue APIs, which has begun with the changes introducing new workqueues and a new alloc_workqueue flag: commit 128ea9f ("workqueue: Add system_percpu_wq and system_dfl_wq") commit 930c2ea ("workqueue: Add new WQ_PERCPU flag") The point of the refactoring is to eventually alter the default behavior of workqueues to become unbound by default so that their workload placement is optimized by the scheduler. Before that to happen, workqueue users must be converted to the better named new workqueues with no intended behaviour changes: system_wq -> system_percpu_wq system_unbound_wq -> system_dfl_wq This way the old obsolete workqueues (system_wq, system_unbound_wq) can be removed in the future. Link: https://lore.kernel.org/all/[email protected]/ Suggested-by: Tejun Heo <[email protected]> Reviewed-by: Christoph Hellwig <[email protected]> Signed-off-by: Marco Crivellari <[email protected]> Signed-off-by: Keith Busch <[email protected]>
1 parent 33eb451 commit 3d553be

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/nvme/target/admin-cmd.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1605,7 +1605,7 @@ void nvmet_execute_keep_alive(struct nvmet_req *req)
16051605

16061606
pr_debug("ctrl %d update keep-alive timer for %d secs\n",
16071607
ctrl->cntlid, ctrl->kato);
1608-
mod_delayed_work(system_wq, &ctrl->ka_work, ctrl->kato * HZ);
1608+
mod_delayed_work(system_percpu_wq, &ctrl->ka_work, ctrl->kato * HZ);
16091609
out:
16101610
nvmet_req_complete(req, status);
16111611
}

drivers/nvme/target/fabrics-cmd-auth.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ void nvmet_execute_auth_send(struct nvmet_req *req)
390390
req->sq->dhchap_step != NVME_AUTH_DHCHAP_MESSAGE_FAILURE2) {
391391
unsigned long auth_expire_secs = ctrl->kato ? ctrl->kato : 120;
392392

393-
mod_delayed_work(system_wq, &req->sq->auth_expired_work,
393+
mod_delayed_work(system_percpu_wq, &req->sq->auth_expired_work,
394394
auth_expire_secs * HZ);
395395
goto complete;
396396
}

0 commit comments

Comments
 (0)