Skip to content

Commit 2ff6cc9

Browse files
juhosggclement
authored andcommitted
arm64: dts: marvell: armada-37xx: drop 'marvell,usb-misc-reg' from USB host nodes
The 'marvell,usb-misc-reg' property is present both in the EHCI and in the XHCI USB host device nodes, however it is not documented. Thus 'make dtbs_check' produces warnings like these: /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@58000 (marvell,armada3700-xhci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected) from schema $id: http://devicetree.org/schemas/usb/generic-xhci.yaml /arch/arm64/boot/dts/marvell/armada-3720-db.dtb: usb@5e000 (marvell,armada-3700-ehci): Unevaluated properties are not allowed ('marvell,usb-misc-reg' was unexpected) from schema $id: http://devicetree.org/schemas/usb/generic-ehci.yaml Apart from the fact that the properties are not documented, those are not even used by any USB host drivers. Due to this, drop the properties in order to get rid of the warnings. Note: With the same name, there is a property used for the Armada 3700 USB UTMI PHYs of which dt-bindings documentation has been added in commit e609586 ("dt-bindings: phy: mvebu-utmi: add UTMI PHY bindings"). Additionally, the property is handled by the 'phy-mvebu-a3700-utmi' driver since commit cc8b7a0 ("phy: add A3700 UTMI PHY driver"). When the nodes of the UTMI PHYs has been added to the SoC dtsi by commit 05d168a ("arm64: dts: marvell: armada-37xx: declare USB2 UTMI PHYs"), the properties has been added to the USB host controller nodes also. According to the commit message this was unintentional, however in regard to the USB hosts, neither the respective documentation, nor driver support has been added into the tree since that. Reviewed-by: Andrew Lunn <[email protected]> Reviewed-by: Miquel Raynal <[email protected]> Signed-off-by: Gabor Juhos <[email protected]> Signed-off-by: Gregory CLEMENT <[email protected]>
1 parent 98226a5 commit 2ff6cc9

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

arch/arm64/boot/dts/marvell/armada-37xx.dtsi

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,7 +369,6 @@
369369
compatible = "marvell,armada3700-xhci",
370370
"generic-xhci";
371371
reg = <0x58000 0x4000>;
372-
marvell,usb-misc-reg = <&usb32_syscon>;
373372
interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
374373
clocks = <&sb_periph_clk 12>;
375374
phys = <&comphy0 0>, <&usb2_utmi_otg_phy>;
@@ -393,7 +392,6 @@
393392
usb2: usb@5e000 {
394393
compatible = "marvell,armada-3700-ehci";
395394
reg = <0x5e000 0x1000>;
396-
marvell,usb-misc-reg = <&usb2_syscon>;
397395
interrupts = <GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>;
398396
phys = <&usb2_utmi_host_phy>;
399397
phy-names = "usb";

0 commit comments

Comments
 (0)