Skip to content

Commit 2f5db9b

Browse files
committed
Merge tag 'drm-xe-next-fixes-2026-02-05' of https://gitlab.freedesktop.org/drm/xe/kernel into drm-next
- Fix CFI violation in debugfs access (Daniele) - Kernel-doc fixes (Chaitanya, Shuicheng) - Disable D3Cold for BMG only on specific platforms (Karthik) Signed-off-by: Dave Airlie <[email protected]> From: Rodrigo Vivi <[email protected]> Link: https://patch.msgid.link/[email protected]
2 parents 3c5ab24 + 666c654 commit 2f5db9b

8 files changed

Lines changed: 20 additions & 11 deletions

File tree

drivers/gpu/drm/xe/abi/guc_scheduler_abi.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
#include <linux/types.h>
1010

11-
/**
11+
/*
1212
* Generic defines required for registration with and submissions to the GuC
1313
* scheduler. Includes engine class/instance defines and context attributes
1414
* (id, priority, etc)

drivers/gpu/drm/xe/xe_guc.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1661,7 +1661,7 @@ void xe_guc_runtime_resume(struct xe_guc *guc)
16611661
xe_guc_submit_unpause(guc);
16621662
}
16631663

1664-
void xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p)
1664+
int xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p)
16651665
{
16661666
struct xe_gt *gt = guc_to_gt(guc);
16671667
u32 status;
@@ -1672,7 +1672,7 @@ void xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p)
16721672
if (!IS_SRIOV_VF(gt_to_xe(gt))) {
16731673
CLASS(xe_force_wake, fw_ref)(gt_to_fw(gt), XE_FW_GT);
16741674
if (!fw_ref.domains)
1675-
return;
1675+
return -EIO;
16761676

16771677
status = xe_mmio_read32(&gt->mmio, GUC_STATUS);
16781678

@@ -1698,6 +1698,8 @@ void xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p)
16981698

16991699
drm_puts(p, "\n");
17001700
xe_guc_submit_print(guc, p);
1701+
1702+
return 0;
17011703
}
17021704

17031705
/**

drivers/gpu/drm/xe/xe_guc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ int xe_guc_self_cfg32(struct xe_guc *guc, u16 key, u32 val);
5353
int xe_guc_self_cfg64(struct xe_guc *guc, u16 key, u64 val);
5454
void xe_guc_irq_handler(struct xe_guc *guc, const u16 iir);
5555
void xe_guc_sanitize(struct xe_guc *guc);
56-
void xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p);
56+
int xe_guc_print_info(struct xe_guc *guc, struct drm_printer *p);
5757
int xe_guc_reset_prepare(struct xe_guc *guc);
5858
void xe_guc_reset_wait(struct xe_guc *guc);
5959
void xe_guc_stop_prepare(struct xe_guc *guc);

drivers/gpu/drm/xe/xe_migrate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1254,7 +1254,7 @@ void xe_migrate_ccs_rw_copy_clear(struct xe_bo *src_bo,
12541254
}
12551255

12561256
/**
1257-
* xe_get_migrate_exec_queue() - Get the execution queue from migrate context.
1257+
* xe_migrate_exec_queue() - Get the execution queue from migrate context.
12581258
* @migrate: Migrate context.
12591259
*
12601260
* Return: Pointer to execution queue on success, error on failure

drivers/gpu/drm/xe/xe_pm.c

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include <linux/fault-inject.h>
99
#include <linux/pm_runtime.h>
1010
#include <linux/suspend.h>
11+
#include <linux/dmi.h>
1112

1213
#include <drm/drm_managed.h>
1314
#include <drm/ttm/ttm_placement.h>
@@ -366,9 +367,15 @@ ALLOW_ERROR_INJECTION(xe_pm_init_early, ERRNO); /* See xe_pci_probe() */
366367

367368
static u32 vram_threshold_value(struct xe_device *xe)
368369
{
369-
/* FIXME: D3Cold temporarily disabled by default on BMG */
370-
if (xe->info.platform == XE_BATTLEMAGE)
371-
return 0;
370+
if (xe->info.platform == XE_BATTLEMAGE) {
371+
const char *product_name;
372+
373+
product_name = dmi_get_system_info(DMI_PRODUCT_NAME);
374+
if (product_name && strstr(product_name, "NUC13RNG")) {
375+
drm_warn(&xe->drm, "BMG + D3Cold not supported on this platform\n");
376+
return 0;
377+
}
378+
}
372379

373380
return DEFAULT_VRAM_THRESHOLD;
374381
}

drivers/gpu/drm/xe/xe_query.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -490,7 +490,7 @@ static int copy_mask(void __user **ptr,
490490

491491
if (copy_to_user(*ptr, topo, sizeof(*topo)))
492492
return -EFAULT;
493-
*ptr += sizeof(topo);
493+
*ptr += sizeof(*topo);
494494

495495
if (copy_to_user(*ptr, mask, mask_size))
496496
return -EFAULT;

drivers/gpu/drm/xe/xe_tlb_inval.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ static void tlb_inval_fini(struct drm_device *drm, void *arg)
112112
}
113113

114114
/**
115-
* xe_gt_tlb_inval_init - Initialize TLB invalidation state
115+
* xe_gt_tlb_inval_init_early() - Initialize TLB invalidation state
116116
* @gt: GT structure
117117
*
118118
* Initialize TLB invalidation state, purely software initialization, should

drivers/gpu/drm/xe/xe_tlb_inval_job.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,7 @@ static void xe_tlb_inval_job_destroy(struct kref *ref)
198198
}
199199

200200
/**
201-
* xe_tlb_inval_alloc_dep() - TLB invalidation job alloc dependency
201+
* xe_tlb_inval_job_alloc_dep() - TLB invalidation job alloc dependency
202202
* @job: TLB invalidation job to alloc dependency for
203203
*
204204
* Allocate storage for a dependency in the TLB invalidation fence. This

0 commit comments

Comments
 (0)