Skip to content

Commit 144297e

Browse files
gal-pressmankuba-moo
authored andcommitted
net/mlx5e: Don't print error message due to invalid module
Dumping module EEPROM on newer modules is supported through the netlink interface only. Querying with old userspace ethtool (or other tools, such as 'lshw') which still uses the ioctl interface results in an error message that could flood dmesg (in addition to the expected error return value). The original message was added under the assumption that the driver should be able to handle all module types, but now that such flows are easily triggered from userspace, it doesn't serve its purpose. Change the log level of the print in mlx5_query_module_eeprom() to debug. Fixes: bb64143 ("net/mlx5e: Add ethtool support for dump module EEPROM") Signed-off-by: Gal Pressman <[email protected]> Reviewed-by: Tariq Toukan <[email protected]> Signed-off-by: Mark Bloch <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 7d36a4a commit 144297e

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

  • drivers/net/ethernet/mellanox/mlx5/core

drivers/net/ethernet/mellanox/mlx5/core/port.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,8 @@ int mlx5_query_module_eeprom(struct mlx5_core_dev *dev,
431431
mlx5_qsfp_eeprom_params_set(&query.i2c_address, &query.page, &offset);
432432
break;
433433
default:
434-
mlx5_core_err(dev, "Module ID not recognized: 0x%x\n", module_id);
434+
mlx5_core_dbg(dev, "Module ID not recognized: 0x%x\n",
435+
module_id);
435436
return -EINVAL;
436437
}
437438

0 commit comments

Comments
 (0)