Skip to content

Commit 12494e5

Browse files
Zqianghtejun
authored andcommitted
sched_ext: Fix some comments in ext.c
This commit update balance_scx() in the comments to balance_one(). Signed-off-by: Zqiang <[email protected]> Reviewed-by: Andrea Righi <[email protected]> Signed-off-by: Tejun Heo <[email protected]>
1 parent b0101cc commit 12494e5

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

kernel/sched/ext.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1577,7 +1577,7 @@ static bool dequeue_task_scx(struct rq *rq, struct task_struct *p, int deq_flags
15771577
*
15781578
* @p may go through multiple stopping <-> running transitions between
15791579
* here and put_prev_task_scx() if task attribute changes occur while
1580-
* balance_scx() leaves @rq unlocked. However, they don't contain any
1580+
* balance_one() leaves @rq unlocked. However, they don't contain any
15811581
* information meaningful to the BPF scheduler and can be suppressed by
15821582
* skipping the callbacks if the task is !QUEUED.
15831583
*/
@@ -2372,7 +2372,7 @@ static void switch_class(struct rq *rq, struct task_struct *next)
23722372
* preempted, and it regaining control of the CPU.
23732373
*
23742374
* ->cpu_release() complements ->cpu_acquire(), which is emitted the
2375-
* next time that balance_scx() is invoked.
2375+
* next time that balance_one() is invoked.
23762376
*/
23772377
if (!rq->scx.cpu_released) {
23782378
if (SCX_HAS_OP(sch, cpu_release)) {
@@ -2478,7 +2478,7 @@ do_pick_task_scx(struct rq *rq, struct rq_flags *rf, bool force_scx)
24782478
}
24792479

24802480
/*
2481-
* If balance_scx() is telling us to keep running @prev, replenish slice
2481+
* If balance_one() is telling us to keep running @prev, replenish slice
24822482
* if necessary and keep running @prev. Otherwise, pop the first one
24832483
* from the local DSQ.
24842484
*/
@@ -4025,7 +4025,7 @@ static DEFINE_TIMER(scx_bypass_lb_timer, scx_bypass_lb_timerfn);
40254025
*
40264026
* - ops.dispatch() is ignored.
40274027
*
4028-
* - balance_scx() does not set %SCX_RQ_BAL_KEEP on non-zero slice as slice
4028+
* - balance_one() does not set %SCX_RQ_BAL_KEEP on non-zero slice as slice
40294029
* can't be trusted. Whenever a tick triggers, the running task is rotated to
40304030
* the tail of the queue with core_sched_at touched.
40314031
*
@@ -6069,7 +6069,7 @@ __bpf_kfunc bool scx_bpf_dsq_move_to_local(u64 dsq_id)
60696069
/*
60706070
* A successfully consumed task can be dequeued before it starts
60716071
* running while the CPU is trying to migrate other dispatched
6072-
* tasks. Bump nr_tasks to tell balance_scx() to retry on empty
6072+
* tasks. Bump nr_tasks to tell balance_one() to retry on empty
60736073
* local DSQ.
60746074
*/
60756075
dspc->nr_tasks++;

0 commit comments

Comments
 (0)