Commit f939e6e
nvme/054: fix nvme reservation preempt and clear operations
This patch fixes two issues in the NVMe reservation test:
1. Missing --prkey parameter for Preempt operation:
According to the nvme-cli documentation, when using resv-acquire
with --racqa=1 (Preempt), the --prkey parameter is required to
specify which reservation key to preempt. Without this parameter,
the command fails with "Invalid Field in Command" error on some
NVMe controllers.
2. Redundant registration in Clear operation:
After a reservation release with --rrela=0, the registration
remains valid. The subsequent resv-register command attempts
to register with the same key, causing a "Reservation Conflict"
error. This redundant registration is unnecessary and should
be removed.
These issues were discovered during my nvme reservation test with
the same steps on NetApp storage connected via NVMe/RDMA.
Link: #190
Signed-off-by: Yi Zhang <[email protected]>
Reviewed-by: Chaitanya Kulkarni <[email protected]>
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>1 parent 2c26a5f commit f939e6e
2 files changed
Lines changed: 2 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
55 | 55 | | |
56 | 56 | | |
57 | 57 | | |
58 | | - | |
| 58 | + | |
59 | 59 | | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
67 | 66 | | |
68 | 67 | | |
69 | 68 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | 57 | | |
59 | | - | |
| 58 | + | |
60 | 59 | | |
61 | 60 | | |
62 | 61 | | |
| |||
0 commit comments