Commit dd55eba
src/Makefile: improve header check for miniublk
After make / make install, src/nvme-passthru-admin-uring is not built
when linux/ublk_cmd.h is missing from userspace kernel headers, even if
liburing is new enough (IORING_OP_URING_CMD). Tests such as nvme/067
then fail with sudo: src/nvme-passthru-admin-uring: command not found.
nvme-passthru-admin-uring does not include linux/ublk_cmd.h; only
miniublk needs it. The Makefile currently ties all C_URING_TARGETS to
the same HAVE_LIBURING + HAVE_UBLK_HEADER gate (or equivalent), so the
NVMe helper is skipped together with miniublk.
When ublk stack is not available, still build metadata and
nvme-passthru-admin-uring if HAVE_LIBURING is 1, and only skip miniublk
with an explicit message when linux/ublk_cmd.h is missing. For that
purpose, split miniublk from the variable C_URING_TARGETS.
Link: #236
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
Signed-off-by: Changhui Zhong <[email protected]>1 parent 078a7ac commit dd55eba
1 file changed
Lines changed: 14 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | | - | |
26 | | - | |
27 | | - | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
28 | 28 | | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | 34 | | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
40 | 47 | | |
41 | 48 | | |
42 | 49 | | |
| |||
0 commit comments