Skip to content

Commit d16a508

Browse files
dwsusekawasaki
authored andcommitted
nvme/{033,034,035,036}: use default subsysnqn variable directly
There is no need to introduce an extra local variable when it uses the default subsysnqn anyway. Reviewed-by: Chaitanya Kulkarni <[email protected]> Signed-off-by: Daniel Wagner <[email protected]> Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 3d1c0fe commit d16a508

4 files changed

Lines changed: 17 additions & 21 deletions

File tree

tests/nvme/033

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,18 +49,17 @@ test_device() {
4949

5050
_setup_nvmet
5151

52-
local subsys="${def_subsysnqn}"
5352
local nsdev
5453
local port
5554

56-
port=$(_nvmet_passthru_target_setup "${subsys}")
55+
port=$(_nvmet_passthru_target_setup "${def_subsysnqn}")
5756

58-
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
57+
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
5958

6059
compare_dev_info "${nsdev}"
6160

62-
_nvme_disconnect_subsys "${subsys}"
63-
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
61+
_nvme_disconnect_subsys "${def_subsysnqn}"
62+
_nvmet_passthru_target_cleanup "${port}" "${def_subsysnqn}"
6463

6564
echo "Test complete"
6665
}

tests/nvme/034

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,17 @@ test_device() {
1919

2020
_setup_nvmet
2121

22-
local subsys="${def_subsysnqn}"
2322
local ctrldev
2423
local nsdev
2524
local port
2625

27-
port=$(_nvmet_passthru_target_setup "${subsys}")
28-
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
26+
port=$(_nvmet_passthru_target_setup "${def_subsysnqn}")
27+
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
2928

3029
_run_fio_verify_io --size="${nvme_img_size}" --filename="${nsdev}"
3130

32-
_nvme_disconnect_subsys "${subsys}"
33-
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
31+
_nvme_disconnect_subsys "${def_subsysnqn}"
32+
_nvmet_passthru_target_cleanup "${port}" "${def_subsysnqn}"
3433

3534
echo "Test complete"
3635
}

tests/nvme/035

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,18 +25,17 @@ test_device() {
2525

2626
_setup_nvmet
2727

28-
local subsys="${def_subsysnqn}"
2928
local ctrldev
3029
local nsdev
3130
local port
3231

33-
port=$(_nvmet_passthru_target_setup "${subsys}")
34-
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
32+
port=$(_nvmet_passthru_target_setup "${def_subsysnqn}")
33+
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
3534

3635
_xfs_run_fio_verify_io "${nsdev}" "${nvme_img_size}"
3736

38-
_nvme_disconnect_subsys "${subsys}"
39-
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
37+
_nvme_disconnect_subsys "${def_subsysnqn}"
38+
_nvmet_passthru_target_cleanup "${port}" "${def_subsysnqn}"
4039

4140
echo "Test complete"
4241
}

tests/nvme/036

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,20 @@ test_device() {
1818

1919
_setup_nvmet
2020

21-
local subsys="${def_subsysnqn}"
2221
local ctrldev
2322
local port
2423

25-
port=$(_nvmet_passthru_target_setup "${subsys}")
26-
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${subsys}")
24+
port=$(_nvmet_passthru_target_setup "${def_subsysnqn}")
25+
nsdev=$(_nvmet_passthru_target_connect "${nvme_trtype}" "${def_subsysnqn}")
2726

28-
ctrldev=$(_find_nvme_dev "${subsys}")
27+
ctrldev=$(_find_nvme_dev "${def_subsysnqn}")
2928

3029
if ! nvme reset "/dev/${ctrldev}" >> "$FULL" 2>&1; then
3130
echo "ERROR: reset failed"
3231
fi
3332

34-
_nvme_disconnect_subsys "${subsys}"
35-
_nvmet_passthru_target_cleanup "${port}" "${subsys}"
33+
_nvme_disconnect_subsys "${def_subsysnqn}"
34+
_nvmet_passthru_target_cleanup "${port}" "${def_subsysnqn}"
3635

3736
echo "Test complete"
3837
}

0 commit comments

Comments
 (0)