Skip to content

Commit bf5d3fa

Browse files
committed
Makefile: follow symbolic links of *.out files
Currently, "make check" uses a find command to ensure that '*.out' files do not have execute permission. However, when an .out file is a symbolic link, it always has execute permission regardless of the true permission of the linked file and the "make check" command fails. This is false- alert. To avoid the false-alert, add -L option to the find command so that it follows symbolic links. With this, the execute permission check is done not for the symbolic links but for the linked files. Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 93b3a68 commit bf5d3fa

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,6 @@ check:
2222
tests/*/rc tests/*/[0-9]*[0-9] src/*.sh
2323
shellcheck --exclude=$(SHELLCHECK_EXCLUDE),SC2154 --format=gcc new
2424
! grep TODO tests/*/rc tests/*/[0-9]*[0-9]
25-
! find -name '*.out' -perm /u=x+g=x+o=x -printf '%p is executable\n' | grep .
25+
! find -L -name '*.out' -perm /u=x+g=x+o=x -printf '%p is executable\n' | grep .
2626

2727
.PHONY: all check install

0 commit comments

Comments
 (0)