scsi/011: allow "set -e" in run_test

kawasaki · kawasaki · commit b6b104bcc708 · 2025-08-18T14:28:44.000+09:00
The test case has the function run_test() which enables bash errexit
feature in it, so that command failures can be caught easily. However,
this errexit feature is not working because the call to run_test() is
followed by '||' operator. (ref: "set -e" description in man bash)

To enable the bash errexit feature in the call to run_test(), do not use
the '||' operator. Instead, check the exit value of the run_test() using
the special parameter '$?'. This triggers the shellcheck warning SC2181
then suppress it.

Signed-off-by: Shin'ichiro Kawasaki &lt;shinichiro.kawasaki@wdc.com&gt;
diff --git a/tests/scsi/011 b/tests/scsi/011
@@ -53,7 +53,9 @@ test() {
 
 	(
 		run_test
-	) || fail=true
+	)
+	# shellcheck disable=SC2181
+	(($? != 0)) && fail=true
 
 	umount "${mount_dir}" >>"${FULL}" 2>&1
 	head -n 999 /sys/bus/pseudo/drivers/scsi_debug/group_number_stats >> "${FULL}"

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,9 @@ test() {`
`53`	`53`
`54`	`54`	`(`
`55`	`55`	`run_test`
`56`		`- ) \|\| fail=true`
	`56`	`+ )`
	`57`	`+ # shellcheck disable=SC2181`
	`58`	`+ (($? != 0)) && fail=true`
`57`	`59`
`58`	`60`	`umount "${mount_dir}" >>"${FULL}" 2>&1`
`59`	`61`	`head -n 999 /sys/bus/pseudo/drivers/scsi_debug/group_number_stats >> "${FULL}"`