Commit b6a7ca0
committed
nvme/rc: fix rdma driver check
Since the commit 4824ac3 ("Skip tests based on SKIP_REASON, not
return value"), blktests no longer checks return values of _have_foo
helpers. Instead, it checks if _have_foo helpers set SKIP_REASON, which
was renamed to SKIP_REASONS later, to judge test case skip. If two
_have_foo helpers are chained with ||, the skip check does not work as
expected since one of the helper may set SKIP_REASONS even when the
other does not set. Such chain with || is done in _nvme_requires() to
check rdma drivers.
To fix the check, do not chain the helper functions with || operator.
Instead, refer $use_rxe to call only the required function.
Reviewed-by: Bart Van Assche <[email protected]>
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>1 parent 1aeff01 commit b6a7ca0
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
44 | 44 | | |
45 | 45 | | |
46 | 46 | | |
47 | | - | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
48 | 52 | | |
49 | 53 | | |
50 | 54 | | |
| |||
0 commit comments