Skip to content

Commit 9a9a365

Browse files
committed
nvme/025: use character device for nvme effects-log command
The recent nvme-cli commit aec85d96e07f ("nvme: add error message for mmap_registers") in the version v2.12 dropped the feature for "nvme effects-log" command to fallback target devices from namespace block devices to admin character devices. This made the test case nvme/025 fail with the message "Block device isn't allowed without csi". To avoid the failure, use admin character devices instead of namespace block devices. Reviewed-by: Chaitanya Kulkarni <[email protected]> Reviewed-by: Daniel Wagner <[email protected]> Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 236edfd commit 9a9a365

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

tests/nvme/025

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,15 @@ test() {
2424

2525
_setup_nvmet
2626

27-
local ns
27+
local nvmedev
2828

2929
_nvmet_target_setup
3030

3131
_nvme_connect_subsys
3232

33-
ns=$(_find_nvme_ns "${def_subsys_uuid}")
33+
nvmedev=$(_find_nvme_dev "${def_subsysnqn}")
3434

35-
if ! nvme effects-log "/dev/${ns}" >> "$FULL" 2>&1; then
35+
if ! nvme effects-log "/dev/${nvmedev}" >> "$FULL" 2>&1; then
3636
echo "ERROR: effects-log failed"
3737
fi
3838

0 commit comments

Comments
 (0)