Skip to content

Commit 9104d53

Browse files
johnpgarrykawasaki
authored andcommitted
nvme: relocate _nvme_requires and _require_nvme_test_img_size
Helper _nvme_requires will be required for md atomics NVMe testing, so relocate to a common file. Helper _require_nvme_test_img_size is referenced by _nvme_requires, so relocate that as well. Signed-off-by: John Garry <[email protected]> Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 650c664 commit 9104d53

2 files changed

Lines changed: 72 additions & 72 deletions

File tree

common/nvme

Lines changed: 72 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1143,3 +1143,75 @@ _test_dev_disables_extended_lba() {
11431143
fi
11441144
return 0
11451145
}
1146+
1147+
_require_nvme_test_img_size() {
1148+
local require_sz_mb
1149+
local nvme_img_size_mb
1150+
1151+
require_sz_mb="$(convert_to_mb "$1")"
1152+
nvme_img_size_mb="$(convert_to_mb "${NVME_IMG_SIZE}")"
1153+
1154+
if ((nvme_img_size_mb < require_sz_mb)); then
1155+
SKIP_REASONS+=("NVME_IMG_SIZE must be at least ${require_sz_mb}m")
1156+
return 1
1157+
fi
1158+
return 0
1159+
}
1160+
1161+
_nvme_requires() {
1162+
_require_nvme_test_img_size 4m
1163+
case ${nvme_trtype} in
1164+
loop)
1165+
_have_driver nvme-loop
1166+
_have_configfs
1167+
;;
1168+
pci)
1169+
_have_driver nvme
1170+
;;
1171+
tcp)
1172+
_have_driver nvme-tcp
1173+
_have_driver nvmet-tcp
1174+
_have_configfs
1175+
;;
1176+
rdma)
1177+
_have_driver nvme-rdma
1178+
_have_driver nvmet-rdma
1179+
_have_configfs
1180+
_have_program rdma
1181+
if [ -n "$USE_RXE" ]; then
1182+
_have_driver rdma_rxe
1183+
else
1184+
_have_driver siw
1185+
fi
1186+
;;
1187+
fc)
1188+
_have_driver nvme-fc
1189+
_have_driver nvme-fcloop
1190+
_have_configfs
1191+
def_adrfam="fc"
1192+
;;
1193+
esac
1194+
1195+
if [[ -n ${nvme_adrfam} ]]; then
1196+
case ${nvme_adrfam} in
1197+
ipv6)
1198+
def_traddr="::1"
1199+
def_adrfam="ipv6"
1200+
;;
1201+
ipv4)
1202+
;; # was already set
1203+
fc)
1204+
def_adrfam="fc"
1205+
;;
1206+
*)
1207+
# ignore for non ip transports
1208+
if [[ "${nvme_trtype}" == "tcp" ||
1209+
"${nvme_trtype}" == "rdma" ]]; then
1210+
SKIP_REASONS+=("unsupported nvme_adrfam=${nvme_adrfam}")
1211+
return 1
1212+
fi
1213+
esac
1214+
fi
1215+
1216+
return 0
1217+
}

tests/nvme/rc

Lines changed: 0 additions & 72 deletions
Original file line numberDiff line numberDiff line change
@@ -54,64 +54,6 @@ _set_nvmet_blkdev_type() {
5454
COND_DESC="bd=${nvmet_blkdev_type}"
5555
}
5656

57-
_nvme_requires() {
58-
_require_nvme_test_img_size 4m
59-
case ${nvme_trtype} in
60-
loop)
61-
_have_driver nvme-loop
62-
_have_configfs
63-
;;
64-
pci)
65-
_have_driver nvme
66-
;;
67-
tcp)
68-
_have_driver nvme-tcp
69-
_have_driver nvmet-tcp
70-
_have_configfs
71-
;;
72-
rdma)
73-
_have_driver nvme-rdma
74-
_have_driver nvmet-rdma
75-
_have_configfs
76-
_have_program rdma
77-
if [ -n "$USE_RXE" ]; then
78-
_have_driver rdma_rxe
79-
else
80-
_have_driver siw
81-
fi
82-
;;
83-
fc)
84-
_have_driver nvme-fc
85-
_have_driver nvme-fcloop
86-
_have_configfs
87-
def_adrfam="fc"
88-
;;
89-
esac
90-
91-
if [[ -n ${nvme_adrfam} ]]; then
92-
case ${nvme_adrfam} in
93-
ipv6)
94-
def_traddr="::1"
95-
def_adrfam="ipv6"
96-
;;
97-
ipv4)
98-
;; # was already set
99-
fc)
100-
def_adrfam="fc"
101-
;;
102-
*)
103-
# ignore for non ip transports
104-
if [[ "${nvme_trtype}" == "tcp" ||
105-
"${nvme_trtype}" == "rdma" ]]; then
106-
SKIP_REASONS+=("unsupported nvme_adrfam=${nvme_adrfam}")
107-
return 1
108-
fi
109-
esac
110-
fi
111-
112-
return 0
113-
}
114-
11557
group_setup() {
11658
if [[ -n "${nvme_target_control}" ]]; then
11759
NVMET_TRTYPES="$(${nvme_target_control} config --show-trtype)"
@@ -157,20 +99,6 @@ _require_test_dev_support_sed() {
15799
return 1
158100
}
159101

160-
_require_nvme_test_img_size() {
161-
local require_sz_mb
162-
local nvme_img_size_mb
163-
164-
require_sz_mb="$(convert_to_mb "$1")"
165-
nvme_img_size_mb="$(convert_to_mb "${NVME_IMG_SIZE}")"
166-
167-
if ((nvme_img_size_mb < require_sz_mb)); then
168-
SKIP_REASONS+=("NVME_IMG_SIZE must be at least ${require_sz_mb}m")
169-
return 1
170-
fi
171-
return 0
172-
}
173-
174102
_require_nvme_cli_auth() {
175103
if ! nvme gen-dhchap-key --nqn nvmf-test-subsys > /dev/null 2>&1 ; then
176104
SKIP_REASONS+=("nvme gen-dhchap-key command missing")

0 commit comments

Comments
 (0)