check: call _unload_modules for each test run

Currently, the check script calls _unload_modules() once per test case.
However, when a test case has set_conditions(), the test case is
executed multiple times, once for each specified condition. Despite
these multiple execution, _unload_modules() is called only once after
all the runs for various conditions have been completed.

This behavior causes module unload problems. When a run leaves some
modules loaded, subsequent runs can be affected by the loaded modules.
To prevent such problems, call _unload_modules() for each test case run
for every condition.

Fixes: fb3ba92 ("check: support test case repeat by different conditions")
Reviewed-by: Daniel Wagner <[email protected]>
Signed-off-by: Shin'ichiro Kawasaki <[email protected]>

Author: kawasaki

check

@@ -416,7 +416,7 @@ _cleanup() {
 	_exit_cgroup2
 }
 
-_call_test() {
+__call_test() {
 	local test_func="$1"
 	local seqres="${RESULTS_DIR}/${TEST_NAME}"
 	# shellcheck disable=SC2034
@@ -536,6 +536,17 @@ _call_test() {
 	fi
 }
 
+_call_test() {
+	local ret
+
+	__call_test "$@"
+	ret=$?
+
+	_unload_modules
+
+	return $ret
+}
+
 _test_dev_is_zoned() {
 	[[ -e "${TEST_DEV_SYSFS}/queue/zoned" &&
 	   $(cat "${TEST_DEV_SYSFS}/queue/zoned") != none ]]
@@ -887,8 +898,6 @@ _run_test() {
 		ret=$?
 	fi
 
-	_unload_modules
-
 	return $ret
 }