Skip to content

Commit 1203c45

Browse files
committed
check: increment bash requirement version from 4.2 to 4.3
The helper functions _get_nvmet_ports() and _get_nvmet_port_params() use the bash 'nameref' feature, introduced in the bash version 4.3. Currently, blktests README and the check script declare bash version 4.2 as the minimum bash version, leading to a version mismatch. Fix this inconsistency by updating the minimum required bash version to 4.3. Note that bash 4.2 was released in 2011, while bash 4.3 was released in 2014. This change is unlikely to affect blktests users. Reviewed-by: Chaitanya Kulkarni <[email protected]> Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 9d472e9 commit 1203c45

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ filesystem testing framework. It was originally written by Omar Sandoval and
1212

1313
The dependencies are minimal, but make sure you have them installed:
1414

15-
- bash (>= 4.2)
15+
- bash (>= 4.3)
1616
- GNU coreutils
1717
- GNU awk
1818
- util-linux

check

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1083,11 +1083,11 @@ _check_dependencies() {
10831083
local -A required_commands_and_packages
10841084
local cmd
10851085
1086-
# Require bash version 4.2
1086+
# Require bash version 4.3
10871087
IFS='.' read -r v1 v2 v3 < <(bash --version | grep version | head -1 | \
10881088
sed 's/.*version \([0-9.]\+\).*/\1/')
1089-
if ((v1 * 65536 + v2 * 256 + v3 < 4 * 65536 + 2 * 256)); then
1090-
_warning "bash version is older than 4.2"
1089+
if ((v1 * 65536 + v2 * 256 + v3 < 4 * 65536 + 3 * 256)); then
1090+
_warning "bash version is older than 4.3"
10911091
fi
10921092
10931093
# Check dependent commands to run blktests

0 commit comments

Comments
 (0)