Skip to content

Commit 0e7aabe

Browse files
committed
md/002: use --run option instead of "echo y"
When mdadm creates a new array, it asks questions to users in the console, which is not suitable for automated test script runs. Then the test case md/002 used "echo y" with pipe to answer the questions automatically. However, starting with mdadm version 4.4, the "echo y" approach no longer works effectively, especially after a commit which introduced a new question [1]. This caused the test case failure. [1] https://git.kernel.org/pub/scm/utils/mdadm/mdadm.git/commit/?h=main&id=e97c4e18c847803016aa60066cb6e57c528d83a6 The --run option is now the recommended alternative because it directly bypasses the questions. To avoid the failure, add the "--run" option to the mdadm create commands instead of the "echo y". Link: #201 Signed-off-by: Shin'ichiro Kawasaki <[email protected]>
1 parent 6b00475 commit 0e7aabe

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

tests/md/002

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,12 @@ test() {
7373
for raid_level in 0 1 10; do
7474
if [ "$raid_level" = 10 ]
7575
then
76-
echo y | mdadm --create /dev/md/blktests_md --level=$raid_level \
77-
--raid-devices=4 --force /dev/"${scsi_0}" /dev/"${scsi_1}" \
76+
mdadm --create /dev/md/blktests_md --level=$raid_level \
77+
--raid-devices=4 --force --run /dev/"${scsi_0}" /dev/"${scsi_1}" \
7878
/dev/"${scsi_2}" /dev/"${scsi_3}" 2> /dev/null 1>&2
7979
else
80-
echo y | mdadm --create /dev/md/blktests_md --level=$raid_level \
81-
--raid-devices=2 --force \
80+
mdadm --create /dev/md/blktests_md --level=$raid_level \
81+
--raid-devices=2 --force --run \
8282
/dev/"${scsi_0}" /dev/"${scsi_1}" 2> /dev/null 1>&2
8383
fi
8484

@@ -214,12 +214,12 @@ test() {
214214

215215
if [ "$raid_level" = 0 ]
216216
then
217-
echo y | mdadm --create /dev/md/blktests_md --level=$raid_level \
218-
--raid-devices=2 --chunk="${md_chunk_size}"K --force \
217+
mdadm --create /dev/md/blktests_md --level=$raid_level \
218+
--raid-devices=2 --chunk="${md_chunk_size}"K --force --run \
219219
/dev/"${scsi_0}" /dev/"${scsi_1}" 2> /dev/null 1>&2
220220
else
221-
echo y | mdadm --create /dev/md/blktests_md --level=$raid_level \
222-
--raid-devices=4 --chunk="${md_chunk_size}"K --force \
221+
mdadm --create /dev/md/blktests_md --level=$raid_level \
222+
--raid-devices=4 --chunk="${md_chunk_size}"K --force --run \
223223
/dev/"${scsi_0}" /dev/"${scsi_1}" \
224224
/dev/"${scsi_2}" /dev/"${scsi_3}" 2> /dev/null 1>&2
225225
fi

0 commit comments

Comments
 (0)