Address review feedback: remove duplicate comments, add default case

JoeMatt · claude · JoeMatt · commit afddc335a5ef · 2026-04-15T19:21:28.000-04:00
- Remove duplicated JPIT register comment block in JERRYReadByte
- Add default return 0 to JERRYReadWord switch for unaligned offsets

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/jerry.c b/src/jerry.c
@@ -384,10 +384,6 @@ uint8_t JERRYReadByte(uint32_t offset, uint32_t who/*=UNKNOWN*/)
    //	F10038          R     xxxxxxxx xxxxxxxx   JPIT2 - timer 1 divider
    //	F1003A          R     xxxxxxxx xxxxxxxx   JPIT3 - timer 2 pre-scaler
    //	F1003C          R     xxxxxxxx xxxxxxxx   JPIT4 - timer 2 divider
-   //	F10036          R     xxxxxxxx xxxxxxxx   JPIT1 - timer 1 pre-scaler
-   //	F10038          R     xxxxxxxx xxxxxxxx   JPIT2 - timer 1 divider
-   //	F1003A          R     xxxxxxxx xxxxxxxx   JPIT3 - timer 2 pre-scaler
-   //	F1003C          R     xxxxxxxx xxxxxxxx   JPIT4 - timer 2 divider
    else if ((offset >= 0xF10036) && (offset <= 0xF1003D))
    {
       uint16_t value;
@@ -447,6 +443,7 @@ uint16_t JERRYReadWord(uint32_t offset, uint32_t who/*=UNKNOWN*/)
          case 0xF10038: return JERRYPIT1Divider;
          case 0xF1003A: return JERRYPIT2Prescaler;
          case 0xF1003C: return JERRYPIT2Divider;
+         default:       return 0;
       }
    }
    else if (offset == 0xF10020)

Original file line number	Diff line number	Diff line change
`@@ -384,10 +384,6 @@ uint8_t JERRYReadByte(uint32_t offset, uint32_t who/=UNKNOWN/)`
`384`	`384`	`// F10038 R xxxxxxxx xxxxxxxx JPIT2 - timer 1 divider`
`385`	`385`	`// F1003A R xxxxxxxx xxxxxxxx JPIT3 - timer 2 pre-scaler`
`386`	`386`	`// F1003C R xxxxxxxx xxxxxxxx JPIT4 - timer 2 divider`
`387`		`- // F10036 R xxxxxxxx xxxxxxxx JPIT1 - timer 1 pre-scaler`
`388`		`- // F10038 R xxxxxxxx xxxxxxxx JPIT2 - timer 1 divider`
`389`		`- // F1003A R xxxxxxxx xxxxxxxx JPIT3 - timer 2 pre-scaler`
`390`		`- // F1003C R xxxxxxxx xxxxxxxx JPIT4 - timer 2 divider`
`391`	`387`	`else if ((offset >= 0xF10036) && (offset <= 0xF1003D))`
`392`	`388`	`{`
`393`	`389`	`uint16_t value;`
`@@ -447,6 +443,7 @@ uint16_t JERRYReadWord(uint32_t offset, uint32_t who/=UNKNOWN/)`
`447`	`443`	`case 0xF10038: return JERRYPIT1Divider;`
`448`	`444`	`case 0xF1003A: return JERRYPIT2Prescaler;`
`449`	`445`	`case 0xF1003C: return JERRYPIT2Divider;`
	`446`	`+ default: return 0;`
`450`	`447`	`}`
`451`	`448`	`}`
`452`	`449`	`else if (offset == 0xF10020)`