Skip to content

Commit 4927669

Browse files
authored
Merge pull request #168 from libretro/revert-167-thread-names
Revert "Add a helper function to set thread name in rthread"
2 parents 9cdb2ab + 7ce487c commit 4927669

2 files changed

Lines changed: 4 additions & 28 deletions

File tree

include/rthreads/rthreads.h

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,8 @@ int sthread_detach(sthread_t *thread);
9090
* @thread to terminate. If that thread has already terminated, then
9191
* it will return immediately. The thread specified by @thread must
9292
* be joinable.
93+
*
94+
* Returns: 0 on success, otherwise it returns a non-zero error number.
9395
*/
9496
void sthread_join(sthread_t *thread);
9597

@@ -101,16 +103,6 @@ void sthread_join(sthread_t *thread);
101103
*/
102104
bool sthread_isself(sthread_t *thread);
103105

104-
/**
105-
* sthread_set_name:
106-
* @thread : pointer to thread object
107-
* @name : name to define for the thread (at most
108-
* 15 bytes)
109-
*
110-
* Set the thread name, useful for debugging.
111-
*/
112-
void sthread_setname(sthread_t *thread, const char *name);
113-
114106
/**
115107
* slock_new:
116108
*

rthreads/rthreads.c

Lines changed: 2 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -285,6 +285,8 @@ int sthread_detach(sthread_t *thread)
285285
* @thread to terminate. If that thread has already terminated, then
286286
* it will return immediately. The thread specified by @thread must
287287
* be joinable.
288+
*
289+
* Returns: 0 on success, otherwise it returns a non-zero error number.
288290
*/
289291
void sthread_join(sthread_t *thread)
290292
{
@@ -318,24 +320,6 @@ bool sthread_isself(sthread_t *thread)
318320
#endif
319321
}
320322

321-
/**
322-
* sthread_set_name:
323-
* @thread : pointer to thread object
324-
* @name : name to define for the thread (at most
325-
* 15 bytes)
326-
*
327-
* Set the thread name, useful for debugging.
328-
*/
329-
void sthread_setname(sthread_t *thread, const char *name)
330-
{
331-
if (!thread)
332-
return;
333-
// TODO: implement that for Windows too.
334-
#ifndef USE_WIN32_THREADS
335-
pthread_setname_np(thread->id, name);
336-
#endif
337-
}
338-
339323
/**
340324
* slock_new:
341325
*

0 commit comments

Comments
 (0)