Don't Sleep to Sync in Non-VRR Normal Running State (#16189)

Ophidon · web-flow · commit f6502b89aa36 · 2024-02-02T06:28:01.000-08:00
The check for sleeping to sync to a specific speed that is meant for fast forward/vrr could be true for a non-vrr normal core running state causing a possible sleep in a situation it was not intended for, especially at higher hz, and thus interfering with frame pacing.
diff --git a/runloop.c b/runloop.c
@@ -7225,7 +7225,13 @@ int runloop_iterate(void)
    }
 
    /* if there's a fast forward limit, inject sleeps to keep from going too fast. */
-   if (runloop_st->frame_limit_minimum_time)
+   if (   (runloop_st->frame_limit_minimum_time)
+          && (   (vrr_runloop_enable)
+              || (runloop_st->flags & RUNLOOP_FLAG_FASTMOTION)
+#ifdef HAVE_MENU
+              || (menu_state_get_ptr()->flags & MENU_ST_FLAG_ALIVE && !(settings->bools.video_vsync))
+#endif
+              || (runloop_st->flags & RUNLOOP_FLAG_PAUSED)))
    {
       const retro_time_t end_frame_time  = cpu_features_get_time_usec();
       const retro_time_t to_sleep_ms     = (

Original file line number	Diff line number	Diff line change
`@@ -7225,7 +7225,13 @@ int runloop_iterate(void)`
`7225`	`7225`	`}`
`7226`	`7226`
`7227`	`7227`	`/* if there's a fast forward limit, inject sleeps to keep from going too fast. */`
`7228`		`- if (runloop_st->frame_limit_minimum_time)`
	`7228`	`+ if ( (runloop_st->frame_limit_minimum_time)`
	`7229`	`+ && ( (vrr_runloop_enable)`
	`7230`	`+ \|\| (runloop_st->flags & RUNLOOP_FLAG_FASTMOTION)`
	`7231`	`+#ifdef HAVE_MENU`
	`7232`	`+ \|\| (menu_state_get_ptr()->flags & MENU_ST_FLAG_ALIVE && !(settings->bools.video_vsync))`
	`7233`	`+#endif`
	`7234`	`+ \|\| (runloop_st->flags & RUNLOOP_FLAG_PAUSED)))`
`7229`	`7235`	`{`
`7230`	`7236`	`const retro_time_t end_frame_time = cpu_features_get_time_usec();`
`7231`	`7237`	`const retro_time_t to_sleep_ms = (`