You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Makefile: auto-detect legacy macOS targets in bundle signing
Pre-Mavericks (< 10.9) codesign predates the '--timestamp' option, so
'make bundle' currently fails on macOS 10.5-10.8 with:
codesign: unrecognized option `--timestamp=none'
The ad-hoc signing step exists to satisfy dyld / hardened-runtime
enforcement on Apple Silicon and recent Intel. That enforcement doesn't
exist on legacy targets, so the signing step isn't just broken there
but unnecessary.
Derive MACOS_LEGACY from BUNDLE_MIN_OS (itself parsed out of
MINVERFLAGS), which means:
- Detection is automatic; no user-specified flag needed.
- Keying off the target OS rather than the build host means
cross-compiling for ppc/10.5 on a modern Mac still takes the
legacy path.
On legacy targets the entire signing block is skipped via a shell
conditional (Make directives can't interleave with recipe lines).
Modern builds are unchanged.
0 commit comments