Remove missing firmware check option (#18470)

sonninnos · web-flow · commit a6ae965b98be · 2025-12-01T22:36:55.000+01:00
diff --git a/config.def.h b/config.def.h
@@ -334,7 +334,6 @@
 #else
 #define DEFAULT_LOAD_DUMMY_ON_CORE_SHUTDOWN true
 #endif
-#define DEFAULT_CHECK_FIRMWARE_BEFORE_LOADING false
 
 /* Specifies whether cores are allowed to
  * present core options in category submenus */
diff --git a/configuration.c b/configuration.c
@@ -1744,7 +1744,6 @@ static struct config_bool_setting *populate_settings_bool(
    SETTING_BOOL("input_descriptor_label_show",   &settings->bools.input_descriptor_label_show, true, DEFAULT_INPUT_DESCRIPTOR_LABEL_SHOW, false);
    SETTING_BOOL("input_descriptor_hide_unbound", &settings->bools.input_descriptor_hide_unbound, true, DEFAULT_INPUT_DESCRIPTOR_HIDE_UNBOUND, false);
    SETTING_BOOL("load_dummy_on_core_shutdown",   &settings->bools.load_dummy_on_core_shutdown, true, DEFAULT_LOAD_DUMMY_ON_CORE_SHUTDOWN, false);
-   SETTING_BOOL("check_firmware_before_loading", &settings->bools.check_firmware_before_loading, true, DEFAULT_CHECK_FIRMWARE_BEFORE_LOADING, false);
    SETTING_BOOL("core_option_category_enable",   &settings->bools.core_option_category_enable, true, DEFAULT_CORE_OPTION_CATEGORY_ENABLE, false);
    SETTING_BOOL("core_info_savestate_bypass",    &settings->bools.core_info_savestate_bypass, true, DEFAULT_CORE_INFO_SAVESTATE_BYPASS, false);
 #if defined(__WINRT__) || defined(WINAPI_FAMILY) && WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP
diff --git a/configuration.h b/configuration.h
@@ -1042,7 +1042,6 @@ typedef struct settings
       bool network_remote_enable;
       bool network_remote_enable_user[MAX_USERS];
       bool load_dummy_on_core_shutdown;
-      bool check_firmware_before_loading;
       bool core_option_category_enable;
       bool core_info_cache_enable;
       bool core_info_savestate_bypass;
diff --git a/core_info.c b/core_info.c
@@ -2263,8 +2263,7 @@ static int core_info_qsort_cmp(const void *a_, const void *b_)
 static bool core_info_list_update_missing_firmware_internal(
       core_info_list_t *core_info_list,
       const char *core_path,
-      const char *systemdir,
-      bool *set_missing_bios)
+      const char *systemdir)
 {
    size_t i;
    char path[PATH_MAX_LENGTH];
@@ -2285,8 +2284,6 @@ static bool core_info_list_update_missing_firmware_internal(
       fill_pathname_join(path, systemdir,
             info->firmware[i].path, sizeof(path));
       info->firmware[i].missing = !path_is_valid(path);
-      if (info->firmware[i].missing && !info->firmware[i].optional)
-         *set_missing_bios = true;
    }
 
    return true;
@@ -2404,14 +2401,13 @@ size_t core_info_count(void)
 }
 
 bool core_info_list_update_missing_firmware(
-      core_info_ctx_firmware_t *info, bool *set_missing_bios)
+      core_info_ctx_firmware_t *info)
 {
    core_info_state_t *p_coreinfo          = &core_info_st;
    if (info)
       return core_info_list_update_missing_firmware_internal(
             p_coreinfo->curr_list,
-            info->path, info->directory.system,
-            set_missing_bios);
+            info->path, info->directory.system);
    return false;
 }
 
diff --git a/core_info.h b/core_info.h
@@ -185,8 +185,7 @@ bool core_info_get_list(core_info_list_t **core);
 /* Returns number of installed cores */
 size_t core_info_count(void);
 
-bool core_info_list_update_missing_firmware(core_info_ctx_firmware_t *info,
-      bool *set_missing_bios);
+bool core_info_list_update_missing_firmware(core_info_ctx_firmware_t *info);
 
 bool core_info_find(const char *core_path,
       core_info_t **core_info);
diff --git a/intl/msg_hash_us.c b/intl/msg_hash_us.c
@@ -85,9 +85,6 @@ int msg_hash_get_help_us_enum(enum msg_hash_enums msg, char *s, size_t len)
           case MENU_ENUM_LABEL_DUMMY_ON_CORE_SHUTDOWN:
              strlcpy(s, msg_hash_to_str(MENU_ENUM_LABEL_HELP_DUMMY_ON_CORE_SHUTDOWN), len);
              break;
-          case MENU_ENUM_LABEL_CHECK_FOR_MISSING_FIRMWARE:
-             strlcpy(s, msg_hash_to_str(MENU_ENUM_LABEL_HELP_CHECK_FOR_MISSING_FIRMWARE), len);
-             break;
           case MENU_ENUM_LABEL_CORE_INFO_SAVESTATE_BYPASS:
              strlcpy(s, msg_hash_to_str(MENU_ENUM_SUBLABEL_CORE_INFO_SAVESTATE_BYPASS), len);
              break;
diff --git a/menu/cbs/menu_cbs_sublabel.c b/menu/cbs/menu_cbs_sublabel.c
@@ -592,7 +592,6 @@ DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_video_vertical_sync,           MENU_
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_video_adaptive_vsync,          MENU_ENUM_SUBLABEL_VIDEO_ADAPTIVE_VSYNC)
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_core_allow_rotate,             MENU_ENUM_SUBLABEL_VIDEO_ALLOW_ROTATE)
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_dummy_on_core_shutdown,        MENU_ENUM_SUBLABEL_DUMMY_ON_CORE_SHUTDOWN)
-DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_dummy_check_missing_firmware,  MENU_ENUM_SUBLABEL_CHECK_FOR_MISSING_FIRMWARE)
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_core_option_category_enable,   MENU_ENUM_SUBLABEL_CORE_OPTION_CATEGORY_ENABLE)
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_core_info_cache_enable,        MENU_ENUM_SUBLABEL_CORE_INFO_CACHE_ENABLE)
 DEFAULT_SUBLABEL_MACRO(action_bind_sublabel_core_info_savestate_bypass,    MENU_ENUM_SUBLABEL_CORE_INFO_SAVESTATE_BYPASS)
@@ -4712,9 +4711,6 @@ int menu_cbs_init_bind_sublabel(menu_file_list_cbs_t *cbs,
          case MENU_ENUM_LABEL_DUMMY_ON_CORE_SHUTDOWN:
             BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_dummy_on_core_shutdown);
             break;
-         case MENU_ENUM_LABEL_CHECK_FOR_MISSING_FIRMWARE:
-            BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_dummy_check_missing_firmware);
-            break;
          case MENU_ENUM_LABEL_CORE_OPTION_CATEGORY_ENABLE:
             BIND_ACTION_SUBLABEL(cbs, action_bind_sublabel_core_option_category_enable);
             break;
diff --git a/menu/menu_displaylist.c b/menu/menu_displaylist.c
@@ -815,7 +815,6 @@ static int menu_displaylist_parse_core_info(
       core_info_ctx_firmware_t firmware_info;
       uint8_t flags                   = content_get_flags();
       bool update_missing_firmware    = false;
-      bool set_missing_firmware       = false;
       bool systemfiles_in_content_dir = settings->bools.systemfiles_in_content_dir;
       bool content_is_inited          = flags & CONTENT_ST_FLAG_IS_INITED;
 
@@ -847,12 +846,7 @@ static int menu_displaylist_parse_core_info(
       else
          firmware_info.directory.system = settings->paths.directory_system;
 
-      update_missing_firmware         = core_info_list_update_missing_firmware(&firmware_info, &set_missing_firmware);
-
-      if (set_missing_firmware)
-         runloop_st->missing_bios     = true;
-      else
-         runloop_st->missing_bios     = false;
+      update_missing_firmware         = core_info_list_update_missing_firmware(&firmware_info);
 
       if (update_missing_firmware)
       {
@@ -11543,7 +11537,6 @@ unsigned menu_displaylist_build_list(
             static const menu_displaylist_build_info_t build_list[] = {
                {MENU_ENUM_LABEL_CORE_INFO_CACHE_ENABLE,            PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_CORE_INFO_SAVESTATE_BYPASS,        PARSE_ONLY_BOOL},
-               {MENU_ENUM_LABEL_CHECK_FOR_MISSING_FIRMWARE,        PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_SYSTEMFILES_IN_CONTENT_DIR_ENABLE, PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_CORE_OPTION_CATEGORY_ENABLE,       PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_DRIVER_SWITCH_ENABLE,              PARSE_ONLY_BOOL},
diff --git a/menu/menu_setting.c b/menu/menu_setting.c
@@ -11067,14 +11067,6 @@ static bool setting_append_list(
             bool_entries[listing].flags         |= SD_FLAG_DEFAULT_VALUE;
             listing++;
 
-            bool_entries[listing].target         = &settings->bools.check_firmware_before_loading;
-            bool_entries[listing].name_enum_idx  = MENU_ENUM_LABEL_CHECK_FOR_MISSING_FIRMWARE;
-            bool_entries[listing].SHORT_enum_idx = MENU_ENUM_LABEL_VALUE_CHECK_FOR_MISSING_FIRMWARE;
-            bool_entries[listing].flags          = SD_FLAG_ADVANCED;
-            if (DEFAULT_CHECK_FIRMWARE_BEFORE_LOADING)
-               bool_entries[listing].flags      |= SD_FLAG_DEFAULT_VALUE;
-            listing++;
-
             bool_entries[listing].target         = &settings->bools.systemfiles_in_content_dir;
             bool_entries[listing].name_enum_idx  = MENU_ENUM_LABEL_SYSTEMFILES_IN_CONTENT_DIR_ENABLE;
             bool_entries[listing].SHORT_enum_idx = MENU_ENUM_LABEL_VALUE_SYSTEMFILES_IN_CONTENT_DIR_ENABLE;
diff --git a/msg_hash.h b/msg_hash.h
@@ -3017,7 +3017,7 @@ enum msg_hash_enums
    MENU_LABEL(NETWORK_USER_REMOTE_ENABLE),
 
    MENU_LBL_H(DUMMY_ON_CORE_SHUTDOWN),
-   MENU_LBL_H(CHECK_FOR_MISSING_FIRMWARE),
+   MENU_LBL_H(CHECK_FOR_MISSING_FIRMWARE), /* Deprecated */
    MENU_LABEL(CORE_INFO_SAVESTATE_BYPASS),
    MENU_LABEL(CORE_OPTION_CATEGORY_ENABLE),
    MENU_LABEL(CORE_INFO_CACHE_ENABLE),
diff --git a/retroarch.cfg b/retroarch.cfg
@@ -751,9 +751,6 @@
 # Prevent libretro cores from closing RetroArch on exit by loading a dummy core.
 # load_dummy_on_core_shutdown = "true"
 
-# Check for firmware requirement(s) before loading a content.
-# check_firmware_before_loading = "false"
-
 #### User Interface
 
 # Start UI companion driver's interface on boot (if available).
diff --git a/runloop.h b/runloop.h
@@ -299,7 +299,6 @@ struct runloop
       char label    [PATH_MAX_LENGTH*2];
    } name;
 
-   bool missing_bios;
    bool perfcnt_enable;
 };
 
diff --git a/tasks/task_content.c b/tasks/task_content.c
diff --git a/ui/drivers/ui_qt.cpp b/ui/drivers/ui_qt.cpp
