Skip to content

Commit 9dd6e85

Browse files
authored
fix writing before string when substring is not found (#17330)
1 parent 50c943a commit 9dd6e85

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

menu/menu_displaylist.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -866,12 +866,15 @@ static int menu_displaylist_parse_core_info(
866866
/* Show relevant note row and skip showing it later */
867867
if (core_info->notes)
868868
{
869+
int spc;
869870
unsigned j;
870871
char firmware_basename[64];
871872
fill_pathname_base(firmware_basename,
872873
core_info->firmware[i].desc, sizeof(firmware_basename));
873874

874-
firmware_basename[string_find_index_substring_string(firmware_basename, " ")] = '\0';
875+
spc = string_find_index_substring_string(firmware_basename, " ");
876+
if (spc >= 0)
877+
firmware_basename[spc] = '\0';
875878

876879
for (j = 0; j < core_info->note_list->size; j++)
877880
{

0 commit comments

Comments
 (0)