fix(vfs): use public VFS API instead of internal _impl functions

- Replace retro_vfs_*_impl with public API
- Revert unrelated XMB changes

Author: 龙虾机器人

fix_c89.py

@@ -0,0 +1,78 @@
+#!/usr/bin/env python3
+import re
+
+with open('menu/menu_vfs_browser.c.fixed', 'r') as f:
+    content = f.read()
+
+# Fix vfs_browser_read_dir function
+old_func = '''static void vfs_browser_read_dir(void)
+{
+   libretro_vfs_implementation_dir *vfs_dir;
+   size_t i;
+   
+   /* Clean up old entries */'''
+
+new_func = '''static void vfs_browser_read_dir(void)
+{
+   libretro_vfs_implementation_dir *vfs_dir;
+   size_t i;
+   const char *name;
+   bool is_dir;
+   uint64_t size;
+   char full_path[PATH_MAX_LENGTH];
+   size_t new_capacity;
+   char **new_names;
+   bool *new_is_dir;
+   uint64_t *new_sizes;
+   
+   /* Clean up old entries */'''
+
+content = content.replace(old_func, new_func)
+
+# Fix variable declarations in while loop
+old_while = '''   /* Read entries */
+   while (retro_vfs_readdir_impl(vfs_dir))
+   {
+      const char *name = retro_vfs_dirent_get_name_impl(vfs_dir);
+      bool is_dir = retro_vfs_dirent_is_dir_impl(vfs_dir);
+      uint64_t size = 0;
+      char full_path[PATH_MAX_LENGTH];'''
+
+new_while = '''   /* Read entries */
+   while (retro_vfs_readdir_impl(vfs_dir))
+   {
+      name = retro_vfs_dirent_get_name_impl(vfs_dir);
+      is_dir = retro_vfs_dirent_is_dir_impl(vfs_dir);
+      size = 0;'''
+
+content = content.replace(old_while, new_while)
+
+# Fix if block variables
+old_if = '''      /* Expand capacity if needed */
+      if (g_vfs_browser.entry_count >= g_vfs_browser.entry_capacity)
+      {
+         size_t new_capacity = g_vfs_browser.entry_capacity * 2;
+         char **new_names = (char**)realloc(g_vfs_browser.entry_names, 
+                                            new_capacity * sizeof(char*));
+         bool *new_is_dir = (bool*)realloc(g_vfs_browser.entry_is_dir, 
+                                           new_capacity * sizeof(bool));
+         uint64_t *new_sizes = (uint64_t*)realloc(g_vfs_browser.entry_sizes, 
+                                                  new_capacity * sizeof(uint64_t));'''
+
+new_if = '''      /* Expand capacity if needed */
+      if (g_vfs_browser.entry_count >= g_vfs_browser.entry_capacity)
+      {
+         new_capacity = g_vfs_browser.entry_capacity * 2;
+         new_names = (char**)realloc(g_vfs_browser.entry_names, 
+                                            new_capacity * sizeof(char*));
+         new_is_dir = (bool*)realloc(g_vfs_browser.entry_is_dir, 
+                                           new_capacity * sizeof(bool));
+         new_sizes = (uint64_t*)realloc(g_vfs_browser.entry_sizes, 
+                                                  new_capacity * sizeof(uint64_t));'''
+
+content = content.replace(old_if, new_if)
+
+with open('menu/menu_vfs_browser.c', 'w') as f:
+    f.write(content)
+
+print("C89 fix applied successfully!")

menu/drivers/xmb.c

@@ -7171,13 +7171,6 @@ static void xmb_render(void *data,
 
          thumbnail_icon = &node->thumbnail_icon;
 
-         /* LOW-MEMORY FIX: Skip loading if already at max concurrent loads */
-         if (!gfx_thumbnail_can_start_load())
-         {
-            node->icon_hide = true;
-            continue;
-         }
-
          if (cur_per_frame >= max_per_frame)
          {
             node->icon_hide = true;
@@ -7310,58 +7303,12 @@ static void xmb_render(void *data,
          xmb->thumbnails_right_status_prev = xmb->thumbnails.right.status;
    }
 
-   /* LOW-MEMORY FIX: Detect rapid scrolling and defer thumbnail loading
-    * This prevents texture exhaustion on devices like Raspberry Pi and Switch */
-   {
-      static retro_time_t last_scroll_time = 0;
-      static unsigned scroll_count = 0;
-      retro_time_t current_time = cpu_features_get_time_usec();
-      
-      /* Count scrolls within 100ms window */
-      if (current_time - last_scroll_time < 100000)
-         scroll_count++;
-      else
-         scroll_count = 1;
-      
-      last_scroll_time = current_time;
-      
-      /* If scrolling rapidly (>5 scrolls in 100ms), skip thumbnail updates
-       * except for the currently selected item */
-      if (scroll_count > 5)
-      {
-         /* Only load thumbnail for selected item */
-         size_t selection = menu_st->selection_ptr;
-         if (selection < selection_buf->size)
-         {
-            xmb_node_t *node = (xmb_node_t*)selection_buf->list[selection].userdata;
-            if (node)
-            {
-               /* Reset all other visible thumbnails to free memory */
-               for (i = menu_st->entries.begin; i < menu_st->entries.end; i++)
-               {
-                  if (i != selection)
-                  {
-                     xmb_node_t *other_node = (xmb_node_t*)selection_buf->list[i].userdata;
-                     if (other_node && other_node != node)
-                        gfx_thumbnail_reset(&other_node->thumbnail_icon.icon);
-                  }
-               }
-            }
-         }
-         
-         /* Skip full thumbnail update - will retry when scrolling stops */
-         xmb->thumbnails.pending_icons = XMB_PENDING_THUMBNAIL_ICONS;
-         goto end;
-      }
-   }
-
    i = menu_st->entries.begin;
 
    if (i >= end)
       menu_st->entries.begin = 0;
 
    GFX_ANIMATION_CLEAR_ACTIVE(p_anim);
-end:;
 }
 
 static void xmb_draw_bg(
@@ -9232,14 +9179,6 @@ static void *xmb_init(void **userdata, bool video_is_threaded)
    gfx_thumbnail_set_stream_delay(-1.0f);
    gfx_thumbnail_set_fade_duration(-1.0f);
    gfx_thumbnail_set_fade_missing(false);
-   
-   /* LOW-MEMORY FIX: Set conservative concurrent load limit
-    * Lower values for low-memory platforms (RPi, Switch, etc.) */
-#if defined(HAVE_OPENGLES) || defined(__SWITCH__) || defined(ANDROID)
-   gfx_thumbnail_set_max_concurrent_loads(2);
-#else
-   gfx_thumbnail_set_max_concurrent_loads(4);
-#endif
 
    xmb->use_ps3_layout                        =
          xmb_use_ps3_layout(settings->uints.menu_xmb_layout, width, height);

menu/menu_vfs_browser.c

@@ -108,10 +108,10 @@ static void vfs_browser_read_dir(void)
    g_vfs_browser.dir = vfs_dir;
 
    /* Read entries */
-   while (retro_vfs_readdir_impl(vfs_dir))
+   while (retro_vfs_readdir(vfs_dir))
    {
-      name = retro_vfs_dirent_get_name_impl(vfs_dir);
-      is_dir = retro_vfs_dirent_is_dir_impl(vfs_dir);
+      name = retro_vfs_dirent_get_name(vfs_dir);
+      is_dir = retro_vfs_dirent_is_dir(vfs_dir);
       size = 0;
 
       if (!name)
@@ -153,14 +153,14 @@ static void vfs_browser_read_dir(void)
       {
          fill_pathname_join(full_path, g_vfs_browser.current_path, name, 
                            sizeof(full_path));
-         size = retro_vfs_stat_impl(full_path, NULL);
+         size = retro_vfs_stat(full_path, NULL);
       }
 
       g_vfs_browser.entry_sizes[g_vfs_browser.entry_count] = size;
       g_vfs_browser.entry_count++;
    }
 
-   retro_vfs_closedir_impl(vfs_dir);
+   retro_vfs_closedir(vfs_dir);
    g_vfs_browser.dir = NULL;
 
    RARCH_LOG("[VFS Browser] Read %zu entries from %s\n", 
@@ -316,7 +316,7 @@ bool menu_vfs_browser_operation(unsigned operation, const char *name, const char
 
       case 2: /* Delete */
          RARCH_LOG("[VFS Browser] Delete: %s\n", full_path);
-         if (retro_vfs_remove_impl(full_path) == 0)
+         if (retro_vfs_remove(full_path) == 0)
          {
             vfs_browser_read_dir(); /* Refresh */
             return true;
@@ -329,7 +329,7 @@ bool menu_vfs_browser_operation(unsigned operation, const char *name, const char
          fill_pathname_join(new_path, g_vfs_browser.current_path, new_name, 
                            sizeof(new_path));
          RARCH_LOG("[VFS Browser] Rename: %s -> %s\n", full_path, new_path);
-         if (retro_vfs_rename_impl(full_path, new_path) == 0)
+         if (retro_vfs_rename(full_path, new_path) == 0)
          {
             vfs_browser_read_dir(); /* Refresh */
             return true;
@@ -338,7 +338,7 @@ bool menu_vfs_browser_operation(unsigned operation, const char *name, const char
 
       case 4: /* Create directory */
          RARCH_LOG("[VFS Browser] Create directory: %s\n", full_path);
-         if (retro_vfs_mkdir_impl(full_path))
+         if (retro_vfs_mkdir(full_path))
          {
             vfs_browser_read_dir(); /* Refresh */
             return true;