Fix many warnings (#16180)

Also change iOS/tvOS to use system zlib instead of compiling it in

Author: warmenhoven

cheevos/cheevos.c

@@ -616,7 +616,7 @@ static void rcheevos_server_error(const char* api_name, const char* message)
       MESSAGE_QUEUE_ICON_DEFAULT, MESSAGE_QUEUE_CATEGORY_ERROR);
 }
 
-static void rcheevos_server_disconnected()
+static void rcheevos_server_disconnected(void)
 {
    CHEEVOS_LOG(RCHEEVOS_TAG "Unable to communicate with RetroAchievements server\n");
 
@@ -633,7 +633,7 @@ static void rcheevos_server_disconnected()
 #endif
 }
 
-static void rcheevos_server_reconnected()
+static void rcheevos_server_reconnected(void)
 {
    CHEEVOS_LOG(RCHEEVOS_TAG "All pending requests synced to RetroAchievements server\n");
 
@@ -731,7 +731,7 @@ int rcheevos_get_richpresence(char* s, size_t len)
       }
    }
 
-   return rc_client_get_rich_presence_message(rcheevos_locals.client, s, (size_t)len);
+   return (int)rc_client_get_rich_presence_message(rcheevos_locals.client, s, (size_t)len);
 }
 
 #else /* !HAVE_RC_CLIENT */

deps/dr/dr_flac.h

@@ -772,7 +772,7 @@ typedef drflac_int32 drflac_result;
 static drflac_bool32 drflac__gIsLZCNTSupported = DRFLAC_FALSE;
 #ifndef DRFLAC_NO_CPUID
 static drflac_bool32 drflac__gIsSSE42Supported = DRFLAC_FALSE;
-static void drflac__init_cpu_caps()
+static void drflac__init_cpu_caps(void)
 {
     int info[4] = {0};
 

deps/xdelta3/xdelta3.c

@@ -1079,7 +1079,7 @@ static uint32_t adler32 (uint32_t adler, const uint8_t *buf, usize_t len)
 {
     uint32_t s1 = adler & 0xffffU;
     uint32_t s2 = (adler >> 16) & 0xffffU;
-    int k;
+    usize_t k;
 
     while (len > 0)
       {

gfx/drivers/gl2.c

@@ -3426,9 +3426,6 @@ static bool gl2_frame(void *data, const void *frame,
    bool use_rgba                       = (video_info->video_st_flags & VIDEO_FLAG_USE_RGBA) ? true : false;
    bool statistics_show                = video_info->statistics_show;
    bool msg_bgcolor_enable             = video_info->msg_bgcolor_enable;
-#ifndef EMSCRIPTEN
-   unsigned black_frame_insertion      = video_info->black_frame_insertion;
-#endif
    int bfi_light_frames;
    unsigned n;
    bool input_driver_nonblock_state    = video_info->input_driver_nonblock_state;
@@ -3442,10 +3439,6 @@ static bool gl2_frame(void *data, const void *frame,
 #endif
 #ifdef HAVE_GFX_WIDGETS
    bool widgets_active                 = video_info->widgets_active;
-#endif
-#ifndef EMSCRIPTEN
-   bool runloop_is_slowmotion          = video_info->runloop_is_slowmotion;
-   bool runloop_is_paused              = video_info->runloop_is_paused;
 #endif
    bool overlay_behind_menu            = video_info->overlay_behind_menu;
 

gfx/drivers/gl3.c

@@ -2503,12 +2503,9 @@ static bool gl3_frame(void *data, const void *frame,
 #if 0
    bool msg_bgcolor_enable                 = video_info->msg_bgcolor_enable;
 #endif
-   unsigned black_frame_insertion          = video_info->black_frame_insertion;
    int bfi_light_frames;
    unsigned n;
    unsigned hard_sync_frames               = video_info->hard_sync_frames;
-   bool runloop_is_paused                  = video_info->runloop_is_paused;
-   bool runloop_is_slowmotion              = video_info->runloop_is_slowmotion;
    bool input_driver_nonblock_state        = video_info->input_driver_nonblock_state;
 #ifdef HAVE_MENU
    bool menu_is_alive                      = (video_info->menu_st_flags & MENU_ST_FLAG_ALIVE) ? true : false;

gfx/gfx_thumbnail_path.c

@@ -403,7 +403,6 @@ bool gfx_thumbnail_set_content_playlist(
    const char *core_name              = NULL;
    const char *db_name                = NULL;
    const struct playlist_entry *entry = NULL;
-   settings_t* settings = config_get_ptr();
 
    if (!path_data)
       return false;

gfx/gfx_widgets.c

@@ -1600,7 +1600,7 @@ void gfx_widgets_frame(void *data)
    /* AI Service overlay */
    if (p_dispwidget->ai_service_overlay_state > 0)
    {
-      int text_length = strlen(p_dispwidget->ai_service_text);
+      size_t text_length = strlen(p_dispwidget->ai_service_text);
 
       gfx_display_set_alpha(p_dispwidget->pure_white, 1.0f);
 
@@ -1638,7 +1638,7 @@ void gfx_widgets_frame(void *data)
 
          if (text_width > (video_width * 0.9f - padding * 2))
          {
-            int text_half     = text_length / 2;
+            size_t text_half  = text_length / 2;
             char *extra_line  = (char*)malloc(sizeof(char) * text_length);
             for (; text_half > 0; text_half--)
             {

gfx/video_driver.c

@@ -4302,8 +4302,8 @@ void video_frame_rest(video_driver_state_t *video_st,
    retro_time_t frame_time_target    = 1000000.0f / settings->floats.video_refresh_rate;
    retro_time_t frame_time           = 0;
    static retro_time_t after_present = 0;
-   int sleep_max                     = frame_time_target / 1000 / 2;
-   int sleep                         = 0;
+   retro_time_t sleep_max            = frame_time_target / 1000 / 2;
+   retro_time_t sleep                         = 0;
    int frame_time_near_req_count     = ceil(settings->floats.video_refresh_rate / 2);
    static int frame_time_over_count  = 0;
    static int frame_time_near_count  = 0;

libretro-common/include/libretro.h

@@ -3129,7 +3129,7 @@ typedef void (RETRO_CALLCONV *retro_netpacket_send_t)(int flags, const void* buf
  * This function is not guaranteed to be thread-safe and must be called during
  * retro_run or any of the netpacket callbacks passed with this interface.
  */
-typedef void (RETRO_CALLCONV *retro_netpacket_poll_receive_t)();
+typedef void (RETRO_CALLCONV *retro_netpacket_poll_receive_t)(void);
 
 /* Called by the frontend to signify that a multiplayer session has started.
  * If client_id is 0 the local player is the host of the session and at this

menu/drivers/ozone.c

@@ -8310,7 +8310,7 @@ static enum menu_action ozone_parse_menu_entry_action(
          {
             ozone->pending_cursor_in_sidebar = false;
             ozone->flags |= OZONE_FLAG_CURSOR_IN_SIDEBAR;
-            ozone_sidebar_goto(ozone, ozone->categories_selection_ptr);
+            ozone_sidebar_goto(ozone, (unsigned)ozone->categories_selection_ptr);
          }
          break;