fix null pointer crash in xmb when scrolling

warmenhoven · warmenhoven · commit 749bc23ecdb6 · 2025-11-14T18:41:06.000-05:00
diff --git a/menu/drivers/xmb.c b/menu/drivers/xmb.c
@@ -7080,7 +7080,12 @@ static void xmb_render(void *data,
       for (i = first; i <= last; i++)
       {
          xmb_node_t *node = (xmb_node_t*)selection_buf->list[i].userdata;
-         xmb_icons_t *thumbnail_icon = &node->thumbnail_icon;
+         xmb_icons_t *thumbnail_icon;
+
+         if (!node)
+            continue;
+
+         thumbnail_icon = &node->thumbnail_icon;
 
          if (cur_per_frame >= max_per_frame)
          {

Original file line number	Diff line number	Diff line change
`@@ -7080,7 +7080,12 @@ static void xmb_render(void *data,`
`7080`	`7080`	`for (i = first; i <= last; i++)`
`7081`	`7081`	`{`
`7082`	`7082`	`xmb_node_t node = (xmb_node_t)selection_buf->list[i].userdata;`
`7083`		`- xmb_icons_t *thumbnail_icon = &node->thumbnail_icon;`
	`7083`	`+ xmb_icons_t *thumbnail_icon;`
	`7084`	`+`
	`7085`	`+ if (!node)`
	`7086`	`+ continue;`
	`7087`	`+`
	`7088`	`+ thumbnail_icon = &node->thumbnail_icon;`
`7084`	`7089`
`7085`	`7090`	`if (cur_per_frame >= max_per_frame)`
`7086`	`7091`	`{`